Description

iritkatriel

opened on Sep 9, 2024

Issue body actions

There is one place in the compiler where it copies a bit of AST and modifies it to add a base class to generic classes.
It would be nice if the compiler didn't need to know how to do this.

Linked PRs

• gh-123881: make compiler add the .generic_base base class without constructing AST nodes #123883
• gh-123881: Add additional test coverage for PEP 695 edge cases #123886
• [3.13] gh-123881: Add additional test coverage for PEP 695 edge cases (GH-123886) #123890
• [3.12] gh-123881: Add additional test coverage for PEP 695 edge cases (GH-123886) #123891

Activity

1. iritkatriel

   added

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Sep 9, 2024
2. sobolevn

   added

   topic-typing

   on Sep 9, 2024
3. sobolevn commented on Sep 9, 2024

   

   sobolevn

   on Sep 9, 2024

   Member

   More actions

   cc @JelleZijlstra who implemented PEP695
4. iritkatriel

   changed the title [-]Compiler should not modify the AST[/-] [+]Compiler should not need to know how to construct AST nodes[/+] on Sep 9, 2024
5. JelleZijlstra

   added a commit that references this issue on Sep 9, 2024

   pythongh-123881: Add additional test coverage for PEP 695 edge cases

   bbe2c7a
6. iritkatriel

   added a commit that references this issue on Sep 10, 2024

   gh-123881: Add additional test coverage for PEP 695 edge cases (#123886)

   b52de7e
7. miss-islington

   added 2 commits that reference this issue on Sep 10, 2024

   pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…

   adae6e7

   pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…

   7732e0b
8. diegorusso

   added a commit that references this issue on Sep 10, 2024

   pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…

   8b2375c
9. JelleZijlstra

   added a commit that references this issue on Sep 10, 2024

   [3.12] gh-123881: Add additional test coverage for PEP 695 edge cases (…

   de20ad9
10. iritkatriel

    added a commit that references this issue on Sep 10, 2024

    gh-123881: make compiler add the .generic_base base class without con…

    a2d0818
11. iritkatriel

    closed this as completedin #123883on Sep 10, 2024
12. Yhg1s

    added a commit that references this issue on Sep 30, 2024

    [3.13] gh-123881: Add additional test coverage for PEP 695 edge cases (…

    601ef40

Issue actions