GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123881: Add additional test coverage for PEP 695 edge cases by JelleZijlstra · Pull Request #123886 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Followup from https://github.com/python/cpython/pull/123883/files#r1750989014

  • Issue: Compiler should not need to know how to construct AST nodes #123881

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-123881: Add additional test coverage for PEP 695 edge cases
bbe2c7a 
Followup from https://github.com/python/cpython/pull/123883/files#r1750989014
@JelleZijlstra
JelleZijlstra requested a review from iritkatriel September 9, 2024 23:16
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Sep 9, 2024
@JelleZijlstra JelleZijlstra added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed tests Tests in the Lib/test dir labels Sep 9, 2024
iritkatriel
iritkatriel approved these changes Sep 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 10, 2024
@iritkatriel
iritkatriel merged commit b52de7e into python:main Sep 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 10, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 10, 2024

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2024
@JelleZijlstra @miss-islington
pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…
adae6e7 
…ythonGH-123886)

(cherry picked from commit b52de7e)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 10, 2024

Copy link
Copy Markdown

GH-123890 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2024
@JelleZijlstra @miss-islington
pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…
7732e0b 
…ythonGH-123886)

(cherry picked from commit b52de7e)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 10, 2024
@bedevere-app

bedevere-app Bot commented Sep 10, 2024

Copy link
Copy Markdown

GH-123891 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 10, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Sep 10, 2024
@JelleZijlstra @diegorusso
pythongh-123881: Add additional test coverage for PEP 695 edge cases (p…
8b2375c 
…ython#123886)
@JelleZijlstra
JelleZijlstra deleted the pep695tests branch September 10, 2024 13:27
JelleZijlstra added a commit that referenced this pull request Sep 10, 2024
@miss-islington @JelleZijlstra
[3.12] gh-123881: Add additional test coverage for PEP 695 edge cases (…
de20ad9 
…GH-123886) (#123891)

gh-123881: Add additional test coverage for PEP 695 edge cases (GH-123886)
(cherry picked from commit b52de7e)

Co-authored-by: Jelle Zijlstra <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @JelleZijlstra
[3.13] gh-123881: Add additional test coverage for PEP 695 edge cases (…
601ef40 
…GH-123886) (#123890)

gh-123881: Add additional test coverage for PEP 695 edge cases (GH-123886)
(cherry picked from commit b52de7e)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.