Description

sobolevn

opened on Sep 24, 2024

Issue body actions

Bug report

result jere is not defined

cpython/Lib/pty.py

Lines 36 to 43 in ad7c778

	slave_fd = os.open(slave_name, os.O_RDWR)
	try:
	from fcntl import ioctl, I_PUSH
	except ImportError:
	return master_fd, slave_fd
	try:
	ioctl(result, I_PUSH, "ptem")
	ioctl(result, I_PUSH, "ldterm")

It should be slave_fd.
Caused by #118826

Thanks to @ambv for finding this.
I have a fix ready.

Linked PRs

• gh-124405: Fix NameError in openpty #124406

Activity

1. sobolevn

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   3.14bugs and security fixesbugs and security fixes

   on Sep 24, 2024
2. sobolevn

   self-assigned this

   on Sep 24, 2024
3. sobolevn

   changed the title [-]NameError in `openpty` after #118826/[/-] [+]NameError in `openpty` after #118826[/+] on Sep 24, 2024
4. sobolevn

   added a commit that references this issue on Sep 24, 2024

   pythongh-124405: Fix `NameError` in `openpty`

   9517274
5. ambv

   added a commit that references this issue on Sep 24, 2024

   gh-124405: Fix `NameError` in `openpty` (#124406)

   17b3bc9
6. hugovk commented on Jan 7, 2025

   

   hugovk

   on Jan 7, 2025

   Member

   More actions

   PR merged, closing 🚀
7. hugovk

   closed this as completedon Jan 7, 2025

Issue actions