GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118824: Remove deprecated `master_open` and `slave_open` from `pty` by sobolevn · Pull Request #118826 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 9, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CC @gpshead who reviewed #92365

  • Issue: Remove deprecated master_open and slave_open from pty #118824

📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-118824: Remove deprecated master_open and slave_open fro…
37b2388 
…m `pty`
@sobolevn
sobolevn requested a review from gpshead May 9, 2024 08:52
@bedevere-app bedevere-app Bot added the awaiting core review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Remove deprecated master_open and slave_open from pty #118824
Closed
ronaldoussoren
ronaldoussoren reviewed May 9, 2024
View reviewed changes
Comment thread Lib/pty.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed May 9, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
95fc77b
@sobolevn
sobolevn force-pushed the issue-118824 branch from e194f94 to 95fc77b Compare May 9, 2024 10:19
@hugovk
Merge branch 'main' into issue-118824
1a0dcd0
hugovk
hugovk reviewed May 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2024-05-09-11-50-26.gh-issue-118824.-jBJQC.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
sobolevn and others added 2 commits May 28, 2024 13:52
@sobolevn @hugovk
Apply suggestions from code review
c73b325 
Co-authored-by: Hugo van Kemenade <[email protected]>
@sobolevn
Merge branch 'main' into issue-118824
7079349
hugovk
hugovk approved these changes May 28, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 28, 2024
@sobolevn
sobolevn merged commit f912e5a into python:main May 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @hugovk @estyxx
pythongh-118824: Remove deprecated master_open and slave_open fro…
9fe427c 
…m `pty` (python#118826)

Co-authored-by: Hugo van Kemenade <[email protected]>
ambv
ambv reviewed Sep 24, 2024
View reviewed changes
Comment thread Lib/pty.py
except ImportError:
return master_fd, slave_fd
try:
ioctl(result, I_PUSH, "ptem")

@ambv ambv Sep 24, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is a NameError now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sobolevn sobolevn Sep 24, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #124406

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn sobolevn mentioned this pull request Sep 24, 2024
NameError in openpty after #118826 #124405
Closed
@hauntsaninja hauntsaninja mentioned this pull request Sep 24, 2024
gh-124405: Fix NameError in openpty #124406
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@ronaldoussoren ronaldoussoren ronaldoussoren left review comments
@hugovk hugovk hugovk approved these changes
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @ambv @ronaldoussoren @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.