Description

sobolevn

opened on Apr 28, 2025

Issue body actions

Following example of #131509 I propose to add mypy type checking in CI for tomllib.

It is fully typed already, we just need to run the CI if something changes.

Linked PRs

• gh-133117: Run mypy on tomllib in CI #133118
• [3.13] gh-133117: Run mypy on tomllib in CI (GH-133118) #133192
• gh-133117: Enable stricter mypy checks for tomllib #133206
• [3.13] gh-133117: Enable stricter mypy checks for tomllib (GH-133206) #133343

Activity

1. sobolevn

   added

   buildThe build process and cross-buildThe build process and cross-build

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Apr 28, 2025
2. sobolevn

   self-assigned this

   on Apr 28, 2025
3. sobolevn

   added 2 commits that reference this issue on Apr 28, 2025

   pythongh-133117: Run mypy on `tomllib` in CI

   1fcd462

   pythongh-133117: Run mypy on `tomllib` in CI

   4c8738f
4. AA-Turner commented on Apr 29, 2025

   

   AA-Turner

   on Apr 29, 2025

   Member

   More actions

   cc @hukkin.

   See also discussion in #128907 re possibly removing annotations from tomllib in the future (post 3.10 EOL) for performance/etc. Given that's a way off though, running mypy may be pragmatic in the meantime.

   A
5. sobolevn

   added a commit that references this issue on Apr 29, 2025

   pythongh-133117: Run mypy on `tomllib` in CI

   3eec25a
6. hukkin commented on Apr 29, 2025

   

   hukkin

   on Apr 29, 2025

   Contributor

   More actions

   I fully support this.

   Reacted by sobolevn and Alex Waygood
7. sobolevn

   added a commit that references this issue on Apr 30, 2025

   gh-133117: Run mypy on `tomllib` in CI (#133118)

   5ea9010
8. miss-islington

   added a commit that references this issue on Apr 30, 2025

   pythongh-133117: Run mypy on `tomllib` in CI (pythonGH-133118)

   b9259e1
9. sobolevn

   added 2 commits that reference this issue on Apr 30, 2025

   [3.13] gh-133117: Run mypy on `tomllib` in CI (GH-133118) (#133192)

   0458554

   pythongh-133117: Enable stricter mypy checks for `tomllib`

   bdf615d
10. picnixz

    added

    type-featureA feature request or enhancementA feature request or enhancement

    on May 1, 2025
11. sobolevn

    added a commit that references this issue on May 3, 2025

    gh-133117: Enable stricter mypy checks for `tomllib` (#133206)

    cb31741
12. miss-islington

    added a commit that references this issue on May 3, 2025

    pythongh-133117: Enable stricter mypy checks for `tomllib` (pythonGH-…

    044e36d
13. sobolevn

    closed this as completedon May 3, 2025
14. sobolevn

    added a commit that references this issue on May 3, 2025

    [3.13] gh-133117: Enable stricter mypy checks for `tomllib` (GH-133206)…

    8525223
15. eli-schwartz commented on Jun 16, 2025

    

    eli-schwartz

    on Jun 16, 2025

    Contributor

    More actions

     * CMP: =dev-lang/python-3.14.0_alpha6 with dev-lang/python-3.14.0_beta2_p1/image
    
    [...]
    
     *  FILES:+usr/lib/python3.14/tomllib/mypy.ini
    
    [...]
    

    The fulfillment of this issue seems to have caused a new file to be installed by make install. The file is likely quite useless outside of the git repo.
16. Pranjal095

    added a commit that references this issue on Jul 12, 2025

    pythongh-133117: Enable stricter mypy checks for `tomllib` (python#13…

    5d1e85a

Issue actions