GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133117: Run mypy on `tomllib` in CI by sobolevn · Pull Request #133118 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Enable type checking of tomllib stdlib folder #133117

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
sobolevn requested review from AlexWaygood, JelleZijlstra and ambv April 28, 2025 22:45
@sobolevn
sobolevn requested review from AA-Turner, encukou, ezio-melotti, hauntsaninja and hugovk as code owners April 28, 2025 22:45
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 28, 2025
Enable type checking of tomllib stdlib folder #133117
Closed
@sobolevn sobolevn added skip news needs backport to 3.13 only security fixes labels Apr 28, 2025
hugovk
hugovk reviewed Apr 29, 2025
View reviewed changes
Comment thread .github/workflows/mypy.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/mypy.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tomllib/_parser.py Outdated

def __init__(self) -> None:
self._flags: dict[str, dict] = {}
self._flags: dict[str, dict[Any, Any]] = {}

@hugovk hugovk Apr 29, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fully typed already, we just need to run the CI if something changes.

Seems it wasn't fully typed already?

Please can you also submit these changes to https://github.com/hukkin/tomli ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sobolevn sobolevn Apr 29, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do it before or after this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Apr 29, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest there first, because we're sort of downstream, but no strong preference from me.

Let's ask @hukkin, @encukou and @hauntsaninja.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@sobolevn sobolevn Apr 29, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: hukkin/tomli#257

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@sobolevn sobolevn mentioned this pull request Apr 29, 2025
Update mypy to 1.15 and use --strict mode hukkin/tomli#257
Merged
AlexWaygood
AlexWaygood reviewed Apr 29, 2025
View reviewed changes
Comment thread Lib/tomllib/mypy.ini Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
pythongh-133117: Run mypy on tomllib in CI
3eec25a
@sobolevn
sobolevn force-pushed the mypy-tomllib branch from a3f70d3 to 3eec25a Compare April 29, 2025 10:09
@sobolevn
Merge branch 'main' into mypy-tomllib
318ffa7
AlexWaygood
AlexWaygood approved these changes Apr 29, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 29, 2025
@sobolevn

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

merging main so CLA can possibly get unstuck :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Merge branch 'main' into mypy-tomllib
f08fad9
@sobolevn

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

I will keep this open for a day or so, waiting for others' feedback :)
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn merged commit 5ea9010 into python:main Apr 30, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 30, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 30, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2025
@sobolevn @miss-islington
pythongh-133117: Run mypy on tomllib in CI (pythonGH-133118)
b9259e1 
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 30, 2025

Copy link
Copy Markdown

GH-133192 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 30, 2025
@sobolevn

sobolevn commented Apr 30, 2025

Copy link
Copy Markdown
Member Author

Now I will work on enabling disallow_any_generics = True, thanks everyone!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit that referenced this pull request Apr 30, 2025
@miss-islington @sobolevn
[3.13] gh-133117: Run mypy on tomllib in CI (GH-133118) (#133192)
0458554 
gh-133117: Run mypy on `tomllib` in CI (GH-133118)
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <[email protected]>
@sobolevn sobolevn mentioned this pull request Apr 30, 2025
gh-133117: Enable stricter mypy checks for tomllib #133206
Merged
@sobolevn sobolevn mentioned this pull request May 11, 2025
gh-133893: asyncio.graph: Replace TextIO annotation with io.Writer #133894
Merged
@eli-schwartz

eli-schwartz commented Jun 16, 2025

Copy link
Copy Markdown
Contributor 
 * CMP: =dev-lang/python-3.14.0_alpha6 with dev-lang/python-3.14.0_beta2_p1/image

[...]

 *  FILES:+usr/lib/python3.14/tomllib/mypy.ini

[...]

This PR seems to have caused a new file to be installed by make install. The file is likely quite useless outside of the git repo.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Jun 16, 2025

Copy link
Copy Markdown
Member Author

@eli-schwartz let's discuss this separatelly :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@ambv ambv Awaiting requested review from ambv
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @eli-schwartz @hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.