Description

encukou

opened on Mar 30, 2022

Issue body actions

BPO	47169
Nosy	@encukou, @kulikjak
PRs	bpo-47169: Add feature macro PY_HAVE_THREAD_NATIVE_ID to the stable ABI definition #32365 bpo-47169: Export PyOS_CheckStack in the Windows stable ABI DLL #32414

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-03-30.15:52:37.045>
labels = ['expert-C-API']
title = "Stable ABI: Some optional (#ifdef'd) functions aren't handled correctly"
updated_at = <Date 2022-04-08.12:49:59.275>
user = 'https://github.com/encukou'

bugs.python.org fields:

activity = <Date 2022-04-08.12:49:59.275>
actor = 'petr.viktorin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['C API']
creation = <Date 2022-03-30.15:52:37.045>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 47169
keywords = ['patch']
message_count = 2.0
messages = ['416377', '416477']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'kulikjak']
pr_nums = ['32365', '32414']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue47169'
versions = []

Linked PRs

• gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build #92046

Activity

1. encukou commented on Mar 30, 2022

   

   encukou

   on Mar 30, 2022

   MemberAuthor

   More actions

   • PyThread_get_thread_native_id is only available when PY_HAVE_THREAD_NATIVE_ID is defined. The test currently always expects it to be available.
   • PyOS_CheckStack is only available when USE_STACKCHECK is defined (i.e. on Windows). It should be exported from the DLL.

   I plan to:

   • add the appropriate metadata
   • improve handling & testing of such optional functions in general
2. encukou

   added

   topic-C-API

   on Mar 30, 2022
3. kulikjak commented on Apr 1, 2022

   

   kulikjakmannequin

   on Apr 1, 2022

   Mannequin

   More actions

   Solaris is affected by missing PyThread_get_thread_native_id; all other symbols from the SYMBOL_NAMES tuple (in test_stable_abi_ctypes.py) are available.
4. ezio-melotti

   transferred this issue fromon Apr 10, 2022
5. encukou

   closed this as completedon Apr 28, 2022
6. encukou commented on Apr 29, 2022

   

   encukou

   on Apr 29, 2022

   MemberAuthor

   More actions

   Reopening: PyModule_Create2 and PyModule_FromDefAndSpec2 are still missing with Py_TRACE_REFS. See Victor's comment: #88299 (comment)
7. encukou

   reopened this on Apr 29, 2022
8. encukou commented on Apr 29, 2022

   

   encukou

   on Apr 29, 2022

   MemberAuthor

   More actions

   PR for skipping checks on Py_TRACE_REFS builds: #92046
9. encukou

   added a commit that references this issue on Jan 29, 2024

   gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build (GH…

   15fe8ce
10. encukou commented on Jan 29, 2024

    

    encukou

    on Jan 29, 2024

    MemberAuthor

    More actions

    It took a while, but, the exceptions are gone now.
11. encukou

    closed this as completedon Jan 29, 2024
12. aisk

    added a commit that references this issue on Feb 11, 2024

    pythongh-91325: Skip Stable ABI checks with Py_TRACE_REFS special bui…

    3e1e4cf

Issue actions