GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build by encukou · Pull Request #92046 · python/cpython

Conversation

@encukou

@encukou encukou commented Apr 29, 2022 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Py_TRACE_REFS is not compatible with Py_LIMITED_API nor with the stable ABI.

  • Issue: Stable ABI: Some optional (#ifdef'd) functions aren't handled correctly #91325

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Skip Stable ABI checks with Py_TRACE_REFS special build
0fa4e68 
This build is not compatible with Py_LIMITED_API nor with
the stable ABI.
@encukou encukou added the skip news label Apr 29, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2022
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@bedevere-bot

bedevere-bot commented Apr 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0fa4e68 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@encukou encukou mentioned this pull request Apr 29, 2022
Stable ABI: Some optional (#ifdef'd) functions aren't handled correctly #91325
Closed
kumaraditya303
kumaraditya303 previously requested changes Dec 13, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Dec 13, 2022
@bedevere-bot

bedevere-bot commented Dec 13, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Dec 14, 2022

Copy link
Copy Markdown
Member Author

... where are my soft cushions, @bedevere-bot ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Merge branch 'main' of github.com:python/cpython into stable-abi-trac…
1adabea 
…e-refs
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2024
@bedevere-bot

bedevere-bot commented Jan 23, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1adabea 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2024
@encukou

encukou commented Jan 23, 2024

Copy link
Copy Markdown
Member Author

No soft cushions, so I've resolved the conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jan 23, 2024

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
encukou reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou dismissed kumaraditya303’s stale review January 24, 2024 12:54

There are no more conflicts.

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting changes labels Jan 24, 2024
@encukou
encukou merged commit 15fe8ce into python:main Jan 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 29, 2024
@encukou
encukou deleted the stable-abi-trace-refs branch January 29, 2024 15:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@encukou @aisk
pythongh-91325: Skip Stable ABI checks with Py_TRACE_REFS special bui…
3e1e4cf 
…ld (pythonGH-92046)

Skip Stable ABI checks with Py_TRACE_REFS special build

This build is not compatible with Py_LIMITED_API nor with
the stable ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.