Description

tiran

opened on Jul 14, 2022

Issue body actions

Bug report

GH-94474 caused several buildbots with GCC to fail to compile _decimal module with --with-pydebug --with-lto option. The problem did not show up when I was testing my PR on the build bot farm. I can reproduce the issue locally with GCC 12.1.1. Build does not fail with non-debug builds. Only the combination of LTO and debug fails for me

../Modules/_decimal/libmpdec/mpdecimal.c: In function ‘exp_to_string’:
../Modules/_decimal/libmpdec/mpdecimal.c:143:1: error: inlining failed in call to ‘always_inline’ ‘mpd_word_digits’: function not considered for inlining
  143 | mpd_word_digits(mpd_uint_t word)
      | ^

Activity

1. tiran

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jul 14, 2022
2. tiran commented on Jul 14, 2022

   

   tiran

   on Jul 14, 2022

   MemberAuthor

   More actions

   _decimal has been broken on LTO + pydebug builds for a while. We just didn't notice because build failure was not fatal and did not cause the buildbot to break. Here is an older build run from two days ago, https://buildbot.python.org/all/#/builders/285/builds/2550
3. tiran

   added 2 commits that reference this issue on Jul 14, 2022

   pythongh-94847: Don't force inlining in debug builds of libmpdec

   20177b4

   gh-94847: Don't force inlining in debug builds of libmpdec (GH-94848)

   97b4121
4. miss-islington

   added a commit that references this issue on Jul 18, 2022

   pythongh-94847: Don't force inlining in debug builds of libmpdec (pyt…

   f8c9943
5. tiran

   closed this as completedon Jul 18, 2022
6. tiran

   added a commit that references this issue on Jul 18, 2022

   [3.11] gh-94847: Don't force inlining in debug builds of libmpdec (GH…

   4607e88

Issue actions