GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94847: Don't force inlining in debug builds of libmpdec (GH-94848) by tiran · Pull Request #94848 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 14, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: _decimal fails to build with --with-pydebug --with-lto on GCC #94847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-94847: Don't force inlining in debug builds of libmpdec
20177b4
@tiran tiran added the needs backport to 3.11 only security fixes label Jul 14, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jul 14, 2022
@tiran tiran mentioned this pull request Jul 14, 2022
gh-93939: Build C extensions without setup.py #94474
Merged
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
@bedevere-bot

bedevere-bot commented Jul 14, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 20177b4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
@tiran tiran changed the title gh-94847: Don't force inlining in debug builds of libmpdec gh-94847: Don't force inlining in debug builds of libmpdec (GH-94848) Jul 18, 2022
@tiran
tiran merged commit 97b4121 into python:main Jul 18, 2022
@tiran
tiran deleted the gh-94847-decimal-lto branch July 18, 2022 06:47
@miss-islington

miss-islington commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2022
@tiran @miss-islington
pythongh-94847: Don't force inlining in debug builds of libmpdec (pyt…
f8c9943 
…honGH-94848)

(cherry picked from commit 97b4121)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 18, 2022

Copy link
Copy Markdown

GH-94951 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 18, 2022
tiran added a commit that referenced this pull request Jul 18, 2022
@miss-islington @tiran
[3.11] gh-94847: Don't force inlining in debug builds of libmpdec (GH…
4607e88 
…-94848) (GH-94951)

Co-authored-by: Christian Heimes <[email protected]>
@vstinner vstinner mentioned this pull request Jun 1, 2026
gh-115119: remove TEST_COVERAGE private macro (_decimal module) #149756
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.