Description

gpshead

opened on Sep 2, 2022

Issue body actions

I had some post-merge TODOs ready in #96499 for improvements specific to the main (3.12) branch. This is a rollup issue for those, they're all small:

• Cleanup: Move int_max_str_digits into PyConfig in 3.12.
• Use int32_t or Py_ssize_t instead of int for the max digits value internally.
• Minor feature: add PEP-578 PySys_Audit hook calls at the new ValueError raise spots.
• Once this ships in 3.11.0: Update the version notes about it in the 3.12 docs to say 3.11 and remove the 3.12 whatsnew text about it. The original PR was created not knowing exactly when we'd be able to merge.

Activity

1. gpshead

   added

   type-featureA feature request or enhancementA feature request or enhancement

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   3.12only security fixesonly security fixes

   on Sep 2, 2022
2. gpshead

   self-assigned this

   on Sep 2, 2022
3. isuruf commented on Sep 18, 2022

   

   isuruf

   on Sep 18, 2022

   Contributor

   More actions

   Could the limit be a configuration option, so that people who build from source can configure the limit?
4. gpshead commented on Sep 19, 2022

   

   gpshead

   on Sep 19, 2022

   MemberAuthor

   More actions

   Could the limit be a configuration option, so that people who build from source can configure the limit?

   Lets have that be its own issue if someone comes up with a compelling use case for it.

   My thinking in not including a configure flag to start with is that anyone who builds from source likely also carries patches to their sources so there isn't a good reason to offer a configure option. We don't want to encourage interpreters built and shipped in different environments to have different limits as that can create compatibility headaches for application and library authors potentially expanding their test matrix.
5. gpshead

   added 3 commits that reference this issue on Sep 19, 2022

   pythongh-96512: Update int_max_str docs to say 3.11.

   b65d078

   gh-96512: Update int_max_str docs to say 3.11 (#96942)

   34de67c

   pythongh-96512: Move int_max_str_digits setting to PyConfig

   cf20758
6. gpshead

   added a commit that references this issue on Oct 3, 2022

   gh-96512: Move int_max_str_digits setting to PyConfig (#96944)

   b0f89cb
7. gpshead

   closed this as completedon Oct 3, 2022
8. carljm

   added a commit that references this issue on Oct 3, 2022

   Merge branch 'main' into dictwatch

   e83abac

Issue actions