GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95778: CVE-2020-10735: Prevent DoS by very large int() by gpshead · Pull Request #96499 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Sep 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Integer to and from text conversions via CPython's bignum int type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

Signed-off-by: Christian Heimes [Red Hat] [email protected]
Tons-of-polishing-up-by: Gregory P. Smith [Google] [email protected]
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

  • Issue: CVE-2020-10735: Prevent DoS by large int<->str conversions #95778

I wrote up a one pager for the release managers. Much of that text wound up in the Issue. Backports PRs already exist. See the issue for links.

Further Discussion

... is taking place in discuss.python.org threads

remaining TODOs (aka project management)

  • After this ships: file a follow-up issue to move int_max_str_digits into PyConfig in 3.12.
  • After this ships: file a feature request to add PySys_Audit hook calls at the new ValueError raise spots.
  • If this ships in 3.11rc2: file an issue to update the version notes about it in the 3.12 docs to say 3.11 and remove the 3.12 whatsnew text.
  • The above are tracked in main branch code cleanups for int_max_str_digits non-backportable TODOs #96512.
  • RedHat's CNA reserved that CVE number, they control interaction and coordination with MITRE on marking it public and assigning the score. - @tiran
  • assign CVSS score
    • Assuming worst case, we they'll likely assign CVSS score 7.5 (High) to the issue, https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H&version=3.1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mazyod and urbanonymous reacted with thumbs up emoji septatrix reacted with thumbs down emoji tiangolo, anthonycepeda, amustaque97, pablodz, yankeexe, Mazyod, and urbanonymous reacted with hooray emoji septatrix reacted with confused emoji tiangolo, humitos, amustaque97, pablodz, yankeexe, Mazyod, and urbanonymous reacted with heart emoji tiangolo, amustaque97, pablodz, yankeexe, and Mazyod reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 👎 1 reaction
  • 🎉 7 reactions
  • 😕 1 reaction
  • ❤️ 7 reactions
  • 🚀 5 reactions
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2022
@gpshead gpshead self-assigned this Sep 2, 2022
This was referenced Sep 2, 2022
[3.11] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96500
Merged
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96501
Merged
[3.9] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96502
Merged
[3.8] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96503
Merged
[3.7] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96504
Merged
@gpshead gpshead added the release-blocker label Sep 2, 2022
@gpshead gpshead assigned Yhg1s Sep 2, 2022
@tiran

tiran commented Sep 2, 2022

Copy link
Copy Markdown
Member

Closing and re-opening ticket. CI isn't starting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran closed this Sep 2, 2022
@tiran tiran reopened this Sep 2, 2022
tiran and others added 18 commits September 1, 2022 22:21
@tiran @gpshead
CVE-2020-10735: Prevent DoS by very large int()
19b28fc 
The text to int parser of Python's int type is not safe against
malicious input. Very large input strings with hundred thousands of
digits can consume several seconds.

The int() now limit the maximum amount of an input string to
5,000 digits.

For comparison total amount of protons in the observable universe is
known as Eddington number. That number has 80 digits.

Signed-off-by: Christian Heimes <[email protected]>
@tiran @gpshead
Default to disable, improve tests and docs
0a96b20
@tiran @gpshead
fix typo
88f6d5d
@tiran @gpshead
More docs (WIP)
70c195e
@tiran @gpshead
Basic documentation for sys functions
e17e93b
@tiran @gpshead
Use ValueError, ignore underscore, scale limit
fbd14b7
@tiran @gpshead
Fix CI
dd74d70
@tiran @gpshead
Address Greg's review
0e01461
@tiran @gpshead
Fix sys.flags len and docs
0b21e5f
@gpshead
Keep the warning, but remove advice about limiting input length in th…
3b38abe 
…e json module.

"It's advised to limit the input to a sensible length." isn't very helpful for the JSON module as, while technically true, the limit needed to avoid hitting things like the int<->str base 10 conversion this issue is about would make a significant percentage of actual JSON used in the real world impractical.

we're limiting the int/str conversion length, that is the best that can be done here - unless someone wants to implement a feature request for JSON to reject int looking fields at a much smaller base10 length limit.
@gpshead
Renamed the APIs & too many other refactorings.
37193ed 
The lumps way too many changes together in one commit, but extricating
them into a series of individual pieces doesn't seem worthwhile at this
stage, it could be done by picking and choosing into a new branch if
there is a reason to do so.  Summarizing off the top of my head after
rereading diffs too many times:

- Renamed the environment variable, -X flag, and names of the new APIs.
- Cleaned up the documentation.
- Refactored and improved some tests.
- Moved the definitions of the default and threshold to a non-public
  header.
- Set the default to 2000 instead of disabled as the Steering Council
  agreed having a default limit made the most sense for our users.
- Lowered the minimum threshold because there seems no harm in allowing
  people to have a lower limit.
- Fixed the other-bases base-10 digits equivalent estimate to be
  consistent with the actual potential base-10 value instead of wildly
  off. Aimed for consistency of number size here rather than any attempt
  to match the performance between bases as that is easier for users to
  understand and doesn't change if our algorithm implementations change.
- Left a couple of notes about what changes look good or not good for a
  security fix backported into a stable release.  It appears the PyConfig
  struct is a public API so we cannot change its definition mid-release.
  Backporting is going to involve something outside of the normal code
  path wise to plumb the new value through.  Ugh.

Questions:
 * [ ] `test_embed` is failing in an odd manner... what's up with that?
 * [ ] Is `_pydecimal` important?  This change makes some of its APIs
   not work based on the values being used.  The unittest suite that
   tests both the C and Python Decimal implementations revealed this
   and needed a higher limit set.  If it relies on ints for arbitrary
   precision Decimal numbers, limits are frequently going to make it
   practically unusuable.
 * [ ] Backporting... we should produce what we believe a 3.11/3.10/3.9
   backport will look like in its own PR branch before making a final
   decision. The most annoying difficulty being the `struct PyConfig`
   issue.
 * [ ] I pondered having values >0 but <threshold just silently be
   rounded up to the threshold value instead of causing an error at
   Python startup time, but we do have other environment variables and
   flags that cause startup time errors based on their value so it
   doesn't seem to matter either way.  If we did that, the setter
   should also do that instead of raising.
@gpshead
Improve the configuring docs.
c90b79f
@gpshead
Stop tying to base10, just use string digits.
fea25ea 
Renamed to `int_max_str_digits` and simplified the logic per @Y1hgs's
comments on the earlier revision.  Less code, less awkward, and simpler
to explain.

Underscores and the sign are uncounted because that makes for the
easiest implementation.
@gpshead
Remove the added now-unneeded helper log tbl fn.
ac9f22f
@gpshead
prevent intdostimeit from emitting errors in test_tools.
da72dd1
@gpshead
Remove a leftover base 10 reference. clarify.
d7e4d7b
@gpshead
versionadded/changed to 3.12
5c7e6d5 
Playing it safe, if this lands in 3.11 before 3.11.0 these can be
updated to 3.11.
@gpshead
Link to the CVE from the main doc.
61a5bc9
gpshead added a commit that referenced this pull request Sep 2, 2022
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96501
8f0fa4b 
)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports #96499 aka 511ca94

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
mdickinson
mdickinson reviewed Sep 3, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
mdickinson
mdickinson reviewed Sep 3, 2022
View reviewed changes
Comment thread Objects/longobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead mentioned this pull request Sep 4, 2022
gh-95778: remove unneeded doc note on float.as_integer_ratio #96553
Merged
light-bringer
light-bringer reviewed Sep 5, 2022
View reviewed changes

@light-bringer light-bringer left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdickinson mdickinson mentioned this pull request Sep 6, 2022
FR: Change int repr on huge values to automatically use hexadecimal #96601
Closed
rurban
rurban reviewed Sep 8, 2022
View reviewed changes
Comment thread Python/initconfig.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@septatrix

septatrix commented Sep 12, 2022

Copy link
Copy Markdown

@gpshead could you maybe link to the respective discussion thread (https://discuss.python.org/t/int-str-conversions-broken-in-latest-python-bugfix-releases/18889/45) directly in the issue? It is already locked and you referred to https://discuss.python.org but given that the linked thread seems to be where the main discussion is happening it might be a bit more accessible and reduce duplicate threads about the same topic.
gpshead reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

good idea, done, link added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ngie-eign

ngie-eign commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

For others that might be curious, the testcases provided in the PR don't repro the issue on 2.7. I'm not sure about older 3.x versions.
PS I know python 2.7 is unsupported by python.org, but some OS distributions are still using python 2.7 in the field in a supported capacity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach added a commit to CAM-Gerlach/cpython that referenced this pull request Oct 16, 2022
@CAM-Gerlach @gpshead
Add int/str security change from issue pythongh-95778 PRs pythongh-96499
12c5273 
 / pythongh-95800

Co-authored-by: Gregory P. Smith <[email protected]>
CAM-Gerlach added a commit to CAM-Gerlach/cpython that referenced this pull request Oct 16, 2022
@CAM-Gerlach @ericsnowcurrently
Add subinterpreters removal from issue pythongh-84694 PRs pythongh-96499
c6d321b 
 / pythongh-93306

Co-authored-by: Eric Snow <[email protected]>
CAM-Gerlach added a commit to CAM-Gerlach/cpython that referenced this pull request Oct 16, 2022
@CAM-Gerlach @ericsnowcurrently
Add subinterpreters removal from issue pythongh-84694 PRs pythongh-96499
6c536da 
 / pythongh-93306

Co-authored-by: Eric Snow <[email protected]>
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
gh-95913: Forward-port int/str security change to 3.11 What's New in main #98344
Merged
gpshead pushed a commit that referenced this pull request Oct 17, 2022
@CAM-Gerlach
gh-95913: Forward-port int/str security change to 3.11 What's New in …
bb38b39 
…main (#98344)

Add int/str security change from issue gh-95778 PRs gh-96499 / gh-95800

Co-authored-by: Gregory P. Smith <[email protected]> [Google]
@ucodery ucodery mentioned this pull request Dec 16, 2022
Correct CVE-2020-10735 documentation #100306
Merged
facebook-github-bot pushed a commit to facebookincubator/MetaPython that referenced this pull request Jan 20, 2023
@itamaro @facebook-github-bot
gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96501)
fcfb677 
Summary:
cherry-picked the upstream 3.10 backport

```
git cherry-pick 8f0fa4b eace09e
```

this one is python/cpython#96537

original commit message below

--------

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca94

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).

Reviewed By: alexmalyshev

Differential Revision: D39369518

fbshipit-source-id: 6ed2def
@itsankitkp itsankitkp mentioned this pull request Jan 5, 2024
sys.flags.int_max_str_digits is not -1 RustPython/RustPython#5139
Closed
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request May 27, 2024
@gpshead
[3.11] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
71632e8 
…500)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca9452033ef95bc7d7fc404b8161068226002

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request May 27, 2024
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
341fd6b 
…501)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca9452033ef95bc7d7fc404b8161068226002

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Jul 17, 2024
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
5bc6489 
…501)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca9452033ef95bc7d7fc404b8161068226002

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
@colesbury colesbury mentioned this pull request Aug 2, 2024
sys.flags.gil should be a "sequence" attribute OR stop adding to the sequence #122575
Closed
@hukkin hukkin mentioned this pull request Oct 10, 2024
Document the security of tomllib for untrusted input #111264
Closed
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Jan 13, 2025
@gpshead
[3.11] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
f0d9480 
…500)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca9452033ef95bc7d7fc404b8161068226002

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Jan 13, 2025
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
5e680cb 
…501)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 511ca9452033ef95bc7d7fc404b8161068226002

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Oct 3, 2025
@gpshead
[3.11] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
3aaeb2e 
…500)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 7c93b7c

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Oct 3, 2025
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
c7e5441 
…501)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 7c93b7c

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
zetaloop pushed a commit to zetaloop/cpython-idle that referenced this pull request Nov 5, 2025
@gpshead
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96…
04dfe89 
…501)

Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.

This PR comes fresh from a pile of work done in our private PSRT security response team repo.

This backports python/cpython#96499 aka 7c93b7c

Signed-off-by: Christian Heimes [Red Hat] <[email protected]>
Tons-of-polishing-up-by: Gregory P. Smith [Google] <[email protected]>
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#).
@johnslavik johnslavik mentioned this pull request Mar 2, 2026
gh-144087: Add support for unicode MINUS SIGN in int, float and complex #144095
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 21, 2026
Fix 0.19.0 release-readiness blockers stbenjam/skillsaw#503
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments
@zooba zooba zooba approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
+4 more reviewers
@rurban rurban rurban left review comments
@tiran tiran tiran left review comments
@mdickinson mdickinson mdickinson left review comments
@light-bringer light-bringer light-bringer left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

@Yhg1s Yhg1s

Labels

release-blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@gpshead @tiran @bedevere-bot @septatrix @ngie-eign @rurban @mdickinson @zooba @terryjreedy @light-bringer @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.