GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-100221: Fix creating dirs in `make sharedinstall` by mgorny · Pull Request #100329 · python/cpython

Conversation

mgorny commented Dec 18, 2022 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Fix creating install directories in make sharedinstall if they exist already outside DESTDIR. The previous make rules assumed that the directories would be created via a dependency on a rule for $(DESTSHARED) that did not fire if the directory did exist outside $(DESTDIR).

While technically $(DESTDIR) could be prepended to the rule name, moving the rules for creating directories straight into the sharedinstall rule seems to fit the common practices better. Since the rule explicitly checks whether the individual directories exist anyway, there seems to be no reason to rely on make determining that implicitly as well.

Issue: make sharedinstall does not create lib-dynload in DESTDIR if lib-dynload exists in system already #100221

Automerge-Triggered-By: GH:zware

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flowdalic reacted with thumbs up emoji

All reactions

👍 1 reaction


          pythongh-100221: Fix creating dirs in make sharedinstall

de72019

Fix creating install directories in `make sharedinstall` if they exist
already outside `DESTDIR`.  The previous make rules assumed that
the directories would be created via a dependency on a rule
for `$(DESTSHARED)` that did not fire if the directory did exist outside
`$(DESTDIR)`.

While technically `$(DESTDIR)` could be prepended to the rule name,
moving the rules for creating directories straight into
the `sharedinstall` rule seems to fit the common practices better.
Since the rule explicitly checks whether the individual directories
exist anyway, there seems to be no reason to rely on make determining
that implicitly as well.

bedevere-bot mentioned this pull request

Dec 18, 2022

make sharedinstall does not create lib-dynload in DESTDIR if lib-dynload exists in system already #100221

Closed

bedevere-bot added the awaiting review label

Dec 18, 2022

thesamesam commented Jan 11, 2023

Copy link

Copy Markdown

Contributor

@Yhg1s Could you take a look please? This is one of a few issues which has popped up during our testing in Gentoo since the early alphas.

(There's #100328 and #98643 too but both of those seem to be moving now.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zware approved these changes

Feb 8, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 8, 2023

zware added 🤖 automerge build The build process and cross-build labels

Feb 8, 2023

miss-islington merged commit 2a8bf25 into python:main

Feb 8, 2023

miss-islington commented Feb 8, 2023

Copy link

Copy Markdown

Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Feb 8, 2023

mgorny commented Feb 8, 2023

Copy link

Copy Markdown

Contributor Author

Thanks!

zware reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zware mentioned this pull request

Feb 8, 2023

gh-100220: Fix error handling in make rules #100328

Merged

carljm added a commit to carljm/cpython that referenced this pull request

Feb 9, 2023


          Merge branch 'main' into inlinecomp2

be3becc

* main: (82 commits)
  pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)
  pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)
  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)
  pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)
  pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)
  pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)
  pythongh-98831: Use opcode metadata for stack_effect() (python#101704)
  pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)
  pythongh-101283: Fix use of unbound variable (pythonGH-101712)
  pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)
  pythongh-101277: Port more itertools static types to heap types (python#101304)
  pythongh-98831: Modernize CALL and family (python#101508)
  pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)
  pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)
  pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)
  pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)
  pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)
  pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)
  pythonGH-101578: Normalize the current exception (pythonGH-101607)
  pythongh-47937: Note that Popen attributes are read-only (python#93070)
  ...

hroncok mentioned this pull request

Apr 9, 2023

make install DESTDIR=... does not create the lib-dynload directory in DESTDIR if the real lib-dynload directory exists #98782

Closed

indygreg mentioned this pull request

Sep 24, 2023

lib/python3.12: File exists when doing make -jN install #109796

Open

Reviewers

zware

zware approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mgorny commented Dec 18, 2022 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thesamesam commented Jan 11, 2023

Uh oh!

miss-islington commented Feb 8, 2023

Uh oh!

mgorny commented Feb 8, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mgorny commented Dec 18, 2022 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.