GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100766: Note that locale.LC_MESSAGES is not universal (GH-100702) by uranusjr · Pull Request #100702 · python/cpython

Conversation

@uranusjr

@uranusjr uranusjr commented Jan 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The LC_MESSAGES value in locale is not universally available. The value is generally imported from C headers through localemodule.c. The sourc notes this specifically:

cpython/Lib/locale.py

Lines 25 to 26 in 73097d9

# Yuck: LC_MESSAGES is non-standard: can't tell whether it exists before
# trying the import. So __all__ is also fiddled at the end of the file.

This makes the fact more visible to users only reading the documentation.

  • Issue: Documentation should mention that locale.LC_MESSAGES is not universal #100766

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@uranusjr
Note that locale.LC_MESSAGES is not universal
addd8ab
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 3, 2023
@FFY00 FFY00 mentioned this pull request Jan 5, 2023
Documentation should mention that locale.LC_MESSAGES is not universal #100766
Closed
@FFY00 FFY00 changed the title Doc: Note that locale.LC_MESSAGES is not universal GH-100766: Note that locale.LC_MESSAGES is not universal Jan 5, 2023
FFY00
FFY00 approved these changes Jan 5, 2023
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr thanks for the fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 5, 2023
@FFY00 FFY00 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jan 5, 2023
@FFY00 FFY00 changed the title GH-100766: Note that locale.LC_MESSAGES is not universal GH-100766: Note that locale.LC_MESSAGES is not universal (GH-100702) Jan 5, 2023
@FFY00
FFY00 merged commit 105e373 into python:main Jan 5, 2023
@miss-islington

miss-islington commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @uranusjr for the PR, and @FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 5, 2023
@bedevere-bot

bedevere-bot commented Jan 5, 2023

Copy link
Copy Markdown

GH-100767 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2023
@uranusjr @miss-islington
pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pytho…
0ec9bba 
…nGH-100702)

(cherry picked from commit 105e373)

Co-authored-by: Tzu-ping Chung <[email protected]>
@bedevere-bot

bedevere-bot commented Jan 5, 2023

Copy link
Copy Markdown

GH-100768 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2023
@uranusjr @miss-islington
pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pytho…
38d29f6 
…nGH-100702)

(cherry picked from commit 105e373)

Co-authored-by: Tzu-ping Chung <[email protected]>
@uranusjr
uranusjr deleted the doc-locale-lc-messages-optional branch January 5, 2023 04:56
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
@carljm
Merge branch 'main' into makefile
64553ee 
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
@carljm
Merge branch 'main' into fieldrepr
60aa562 
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
  Drop myself from pathlib maintenance (python#100757)
  pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@uranusjr @miss-islington @bedevere-bot @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.