GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. by markshannon · Pull Request #100753 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jan 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Stats show that it doesn't work. It represents about 0.02% of the instructions executed and its miss rate is over 90%.

  • Issue: Finish up LOAD_ATTR specialisation #100288

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Remove LOAD_ATTR_METHOD_WITH_DICT instruction.
b63534d
@bedevere-bot bedevere-bot added the awaiting core review label Jan 4, 2023
@markshannon markshannon changed the title Remove LOAD_ATTR_METHOD_WITH_DICT instruction. Gh-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. Jan 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 4, 2023
Finish up LOAD_ATTR specialisation #100288
Closed
1 of 2 tasks
@markshannon markshannon changed the title Gh-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. GH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. Jan 4, 2023
@markshannon
markshannon requested a review from Fidget-Spinner January 4, 2023 16:56
Fidget-Spinner
Fidget-Spinner approved these changes Jan 4, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 4, 2023
@markshannon
Merge branch 'main' into remove-load-attr-method-with-dict
e112966
@markshannon
markshannon merged commit f20c553 into python:main Jan 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 5, 2023
@markshannon
markshannon deleted the remove-load-attr-method-with-dict branch January 5, 2023 12:20
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
@carljm
Merge branch 'main' into makefile
64553ee 
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
@carljm
Merge branch 'main' into fieldrepr
60aa562 
* main:
  pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)
  pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
  Drop myself from pathlib maintenance (python#100757)
  pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)
@brandtbucher brandtbucher mentioned this pull request Jan 26, 2023
GH-100288: Skip extra work when failing to specialize LOAD_ATTR #101354
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @Fidget-Spinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.