GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101277: Finalise isolating itertools by erlend-aasland · Pull Request #101305 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add repeat, islice, chain, tee, teedataobject, and batched types to module state.

  • Issue: Isolate the itertools extension module #101277

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 January 24, 2023 23:50
@bedevere-bot bedevere-bot added the awaiting core review label Jan 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Isolate the itertools extension module #101277
Closed
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-4 branch from 244bc33 to e5bf6f8 Compare January 25, 2023 09:02
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-4 branch from e5bf6f8 to a9b84f0 Compare February 1, 2023 14:27
erlend-aasland added 10 commits February 8, 2023 21:28
@erlend-aasland
pythongh-101277: Add repeat type to module state
9a4b14c
@erlend-aasland
pythongh-101277: Add islice type to module state
a66b888
@erlend-aasland
pythongh-101277: Add chain type to module state
d18169b
@erlend-aasland
pythongh-101277: Add tee type to module state
e574de1
@erlend-aasland
pythongh-101277: Add tee data object type to module state
053b759
@erlend-aasland
Add NEWS
94972ba
@erlend-aasland
Purge globals-to-fix.tsv
da57b52
@erlend-aasland
Make chain and repeat immutable
e937984
@erlend-aasland
Add batched type to module state
4264f8b
@erlend-aasland
Use PyType_GetModuleState for types which cannot be subclassed
930fbe1
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-4 branch from a9b84f0 to 930fbe1 Compare February 8, 2023 20:29
erlend-aasland added 3 commits February 8, 2023 21:40
@erlend-aasland
Revert unneeded changes that made the code more readable
d45d438
@erlend-aasland
Ditto
cf3d528
@erlend-aasland
Ditto again
c4981ff
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-4 branch from ed58cc0 to c4981ff Compare February 8, 2023 20:52
erlend-aasland added 5 commits February 8, 2023 22:08
@erlend-aasland
Store state in accumulateobject to speed up __reduce__
1a86a5d
@erlend-aasland
Store state in teeobject to speed up __setstate__
b57d177
@erlend-aasland
Remove unneeded change that made the code more readable
d7bd16a
@erlend-aasland
Speed up teedataobject_jumplink() by passing state from teeobject
d16bed1
@erlend-aasland
Remove unneeded PEP-7 change
68e63dd
erlend-aasland
erlend-aasland commented Feb 8, 2023
View reviewed changes
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title gh-101277: Isolate itertools, part 4/4 gh-101277: Finalise isolating itertools Feb 8, 2023
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 8, 2023 21:50
@erlend-aasland
erlend-aasland requested a review from rhettinger as a code owner February 8, 2023 21:50
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 8, 2023
@erlend-aasland
Fix tee_copy
9f68cd1
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 9f68cd1 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
erlend-aasland added 2 commits February 9, 2023 08:54
@erlend-aasland
Sync with main
ef2d52f
@erlend-aasland
Visit and clear teedataobject_type
a9c6ce5
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit a9c6ce5 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
erlend-aasland added 3 commits February 9, 2023 10:14
@erlend-aasland
Add clear methods to all types
8f554f4
@erlend-aasland
Sync with main
1351172
@erlend-aasland
Revert "Add clear methods to all types"
5213d1f 
This reverts commit 8f554f4.
arhadthedev
arhadthedev reviewed Feb 10, 2023
View reviewed changes
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 10, 2023
@bedevere-bot

bedevere-bot commented Feb 10, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 5213d1f 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 10, 2023
kumaraditya303
kumaraditya303 reviewed Feb 10, 2023
View reviewed changes
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Feb 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 10, 2023
@erlend-aasland erlend-aasland added the 🤖 automerge label Feb 10, 2023
@erlend-aasland

erlend-aasland commented Feb 10, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews, Kumar. Highly appreciated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 826bf0e into python:main Feb 10, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 10, 2023
@erlend-aasland
erlend-aasland deleted the isolate-itertools/batch-4 branch February 10, 2023 11:59
@kumaraditya303

kumaraditya303 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Thanks for the reviews, Kumar. Highly appreciated.

Thanks for all your work on this!
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 10, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for all your work on this!

_io next?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

_io next?

Go ahead! I expect that there will be some bootstrapping issues but I'll help you out.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
36b2917 
* main:
  Docs: Fix getstatus() -> getcode() typos (python#101296)
  Docs: use parameter list for sqlite3.Cursor.execute* (python#101782)
  pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784)
  pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787)
  pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762)
  pythongh-101277: Finalise isolating itertools (pythonGH-101305)
  pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @miss-islington @kumaraditya303 @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.