GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101517: bdb should not lookup linecache with lineno=None by iritkatriel · Pull Request #101787 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 10, 2023

Copy link
Copy Markdown
Member

The root cause of gh-101517 is that the line number was missing in the bytecode, but pdb should not have failed the way it did.

This PR makes bdb check that the lineno is not None before looking it up in the linecache.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-101517: bdb should not lookup linecache with lineno=None
c33144a
@bedevere-bot bedevere-bot added the awaiting core review label Feb 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2023
Bug in linecache when raising exceptiongroup that contains ZeroDivisionError + other exception. #101517
Closed
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error needs backport to 3.10 stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes labels Feb 10, 2023
@blurb-it
📜🤖 Added by blurb_it.
8d770b1
kumaraditya303
kumaraditya303 approved these changes Feb 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 10, 2023
@iritkatriel
iritkatriel merged commit 366b949 into python:main Feb 10, 2023
@miss-islington

miss-islington commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 10, 2023
@bedevere-bot

bedevere-bot commented Feb 10, 2023

Copy link
Copy Markdown

GH-101793 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 10, 2023
@bedevere-bot

bedevere-bot commented Feb 10, 2023

Copy link
Copy Markdown

GH-101794 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2023
@iritkatriel @miss-islington
pythongh-101517: make bdb avoid looking up in linecache with lineno=N…
21424c9 
…one (pythonGH-101787)

(cherry picked from commit 366b949)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2023
@iritkatriel @miss-islington
pythongh-101517: make bdb avoid looking up in linecache with lineno=N…
31cf719 
…one (pythonGH-101787)

(cherry picked from commit 366b949)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington added a commit that referenced this pull request Feb 10, 2023
@miss-islington @iritkatriel
gh-101517: make bdb avoid looking up in linecache with lineno=None (G…
6d8ef96 
…H-101787)

(cherry picked from commit 366b949)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington added a commit that referenced this pull request Feb 10, 2023
@miss-islington @iritkatriel
gh-101517: make bdb avoid looking up in linecache with lineno=None (G…
b0bba7a 
…H-101787)

(cherry picked from commit 366b949)

Co-authored-by: Irit Katriel <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
36b2917 
* main:
  Docs: Fix getstatus() -> getcode() typos (python#101296)
  Docs: use parameter list for sqlite3.Cursor.execute* (python#101782)
  pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784)
  pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787)
  pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762)
  pythongh-101277: Finalise isolating itertools (pythonGH-101305)
  pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Mar 17, 2023
@iritkatriel
Revert "pythongh-101517: make bdb avoid looking up in linecache with …
3cb1bf2 
…lineno=None (python#101787)"

This reverts commit 366b949.
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Mar 18, 2023
@iritkatriel
Revert "pythongh-101517: make bdb avoid looking up in linecache with …
019ed40 
…lineno=None (python#101787)"

This reverts commit 366b949.
@iritkatriel
iritkatriel deleted the bdb_bug branch April 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.