GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101754: document that on Windows, keys in `os.environ` are converted to uppercase by OTheDev · Pull Request #101840 · python/cpython

Conversation

@OTheDev

@OTheDev OTheDev commented Feb 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Tries to fix #101754.

Relevant:

  • https://stackoverflow.com/questions/7797269/python-environment-case-senstivity-os-environ
  • https://stackoverflow.com/questions/19023238/why-python-uppercases-all-environment-variables-in-windows

This PR adds the third note:

prfix

  • Issue: Document that os.environ forcibly upper-cases keys on case-insensitive OSs #101754

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
oda-gitso
fix-issue-101754
1bed00f
@bedevere-bot bedevere-bot added the awaiting review label Feb 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 12, 2023
Document that os.environ forcibly upper-cases keys on case-insensitive OSs #101754
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Feb 12, 2023
@brettcannon
brettcannon requested a review from zooba March 2, 2023 00:35
@zooba

zooba commented Mar 2, 2023

Copy link
Copy Markdown
Member

Looks fine. I think we can move it up to just below the "On Unix" paragraph that talks about encodings. The uppercasing is handled in roughly the same way that the encoding is, so may as well be presented at the same level.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OTheDev
Address review and move note below 'On Unix'
19f0c6b
@OTheDev

OTheDev commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @zooba, I've moved it to a new paragraph just below the "On Unix" one. Here's how it looks now

sc

Please let me know if there is anything else :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 4e7c0cb into python:main Mar 3, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Mar 3, 2023
@zooba

zooba commented Mar 3, 2023

Copy link
Copy Markdown
Member

That's great, thanks!
OTheDev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added OS-windows needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 3, 2023
@miss-islington

miss-islington commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @OTheDev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @OTheDev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 3, 2023

Copy link
Copy Markdown

GH-102393 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2023
@OTheDev @miss-islington
pythongh-101754: Document that Windows converts keys in os.environ …
755862e 
…to uppercase (pythonGH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 3, 2023

Copy link
Copy Markdown

GH-102394 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2023
@OTheDev @miss-islington
pythongh-101754: Document that Windows converts keys in os.environ …
6082c4f 
…to uppercase (pythonGH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <[email protected]>
miss-islington added a commit that referenced this pull request Mar 3, 2023
@miss-islington @OTheDev
gh-101754: Document that Windows converts keys in os.environ to upp…
3d88b4e 
…ercase (GH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <[email protected]>
miss-islington added a commit that referenced this pull request Mar 3, 2023
@miss-islington @OTheDev
gh-101754: Document that Windows converts keys in os.environ to upp…
32a738e 
…ercase (GH-101840)

(cherry picked from commit 4e7c0cb)

Co-authored-by: Owain Davies <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 4, 2023
@carljm
Merge branch 'main' into nodeaddict
a31af32 
* main:
  pythongh-102021 : Allow multiple input files for interpreter loop generator (python#102022)
  Add import of `unittest.mock.Mock` in documentation (python#102346)
  pythongh-102383: [docs] Arguments of `PyObject_CopyData` are `PyObject *` (python#102390)
  pythongh-101754: Document that Windows converts keys in `os.environ` to uppercase (pythonGH-101840)
  pythongh-102324: Improve tests of `typing.override` (python#102325)
@OTheDev
OTheDev deleted the fix-issue-101754 branch January 28, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that os.environ forcibly upper-cases keys on case-insensitive OSs

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@OTheDev @zooba @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.