GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — gh-102021 : Allow multiple input files for interpreter loop generator by jbower-fb · Pull Request #102022 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@gvanrossum @iritkatriel as authors of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I would like to wait reviewing until I am back from my break, around 2/27. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I have a few suggestions, feel free to push back!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| families: dict[str, parser.Family] | ||
|
|
||
| def every_thing(self) -> Iterable[parser.InstDef | parser.Super | parser.Macro]: | ||
| return itertools.chain( |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of itertools.chain. Maybe make this a generator?
I also noticed this is causing the output to be emitted in a different order again. But I quite like having the generated instructions in the same order as they occur in the input. Could you restore that behavior? (I understand that it's a little tricky due to overrides. Ideally there would be a comment left in the output for instructions that are overridden by later ones.)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've changed things now so the output will retain the definition order and if there are overrides they'll look something like this:
...
// TARGET(NOP) overridden by later definition
...
// Override
TARGET(NOP) {
DISPATCH();
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
d8c3165 to
c8495cd
Compare
There was an error while loading. Please reload this page.
|
(In the future please don't force push. It makes things more complicated for the reviewer, and we squash commits at the end anyway.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LG!
I'll apply the small correction to the metadata header comment, wait for tests to pass again, and merge it. Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Great, thank you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
* main: pythongh-102021 : Allow multiple input files for interpreter loop generator (python#102022) Add import of `unittest.mock.Mock` in documentation (python#102346) pythongh-102383: [docs] Arguments of `PyObject_CopyData` are `PyObject *` (python#102390) pythongh-101754: Document that Windows converts keys in `os.environ` to uppercase (pythonGH-101840) pythongh-102324: Improve tests of `typing.override` (python#102325)
…erator (python#102022) The input files no longer use `-i`.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.