GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-88233: zipfile: refactor _strip_extra by jaraco · Pull Request #102083 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • zipfile: handle extras after a zip64 extra
  • Add NEWS entry for bugfix
  • Fix typo
  • Tweak style to conform to best conventions. Remove unused variable.
  • Reflow comment to 72 characters per PEP 8.
  • Replace literal and ambiguous comment with a self-documenting constant.
  • cmath module documentation is misleading on branch cuts #85417: Clarify behaviour on branch cuts in cmath module (gh-85417: Clarify behaviour on branch cuts in cmath module #102046)
  • Misc improvements to the float tutorial (Misc improvements to the float tutorial #102052)
  • PyErr_SetObject() behavior is strange and not as documented. #101578: Amend PyErr_{Set,Get}RaisedException docs (gh-101578: Amend PyErr_{Set,Get}RaisedException docs #101962)
  • Compiler warning for _Py_InIntegralTypeRange #97786: Fix compiler warnings in pytime.c (gh-97786: Fix compiler warnings in pytime.c #101826)
  • CI: intermittent macOS failures for make checksharedmods #101981: Build macOS as recommended by the devguide (gh-101981: Build macOS as recommended by the devguide #102070)
  • Isolate the _io extension module #101819: Adapt _io types to heap types, batch 1 (gh-101819: Adapt _io types to heap types, batch 1 #101949)
  • code.h uses MS-only C++ extensions #101907: Stop using _Py_OPCODE and _Py_OPARG macros (gh-101907: Stop using _Py_OPCODE and _Py_OPARG macros #101912)
  • CI: intermittent macOS failures for make checksharedmods #101981: Apply HOMEBREW related environment variables (gh-101981: Apply HOMEBREW related environment variables #102074)
  • Refactor zipfile._strip_extra to use higher level abstractions for extras instead of a heavy-state loop.
  • Issue: Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
thatch and others added 15 commits February 20, 2023 11:48
@thatch @jaraco
zipfile: handle extras after a zip64 extra
dae825b
Previously, any data _after_ the zip64 extra would be removed.

With many new tests.

Fixes python#88233
@thatch @jaraco
Add NEWS entry for bugfix
03494d9
@jaraco
Fix typo
7e3627c
@jaraco
Tweak style to conform to best conventions. Remove unused variable.
31b71a9
@jaraco
Reflow comment to 72 characters per PEP 8.
6f42280
@jaraco
Replace literal and ambiguous comment with a self-documenting constant.
14d9e42
@mdickinson @jaraco
pythongh-85417: Clarify behaviour on branch cuts in cmath module (pyt…
3c6360e
…hon#102046)

This PR updates the cmath module documentation to reflect the reality that Python is almost always (and as far as I can tell, that "almost" can be omitted) running on a machine whose C double supports signed zeros.

* Removes misleading references to functions being continuous from above / below / the left / the right at branch cuts
* Expands the note on branch cuts at the top of the module documentation to explain the double-sided sign-of-zero-based behaviour
@rhettinger @jaraco
Misc improvements to the float tutorial (pythonGH-102052)
3055af6
@erlend-aasland @CAM-Gerlach @jaraco
pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#10…
a0004e1
…1962)

Co-authored-by: C.A.M. Gerlach <[email protected]>
@mdickinson @jaraco
pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
c6f8395
Fixes compiler warnings in pytime.c.
@erlend-aasland @jaraco
pythongh-101981: Build macOS as recommended by the devguide (pythonGH…
462aaa3
…-102070)

Automerge-Triggered-By: GH:erlend-aasland
@erlend-aasland @jaraco
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949
13882e0
)

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

Automerge-Triggered-By: GH:erlend-aasland
@zooba @jaraco
pythongh-101907: Stop using _Py_OPCODE and _Py_OPARG macros (pyth…
ca5d36e
…onGH-101912)

* pythongh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h

* Make cases_generator correct on Windows
@corona10 @jaraco
pythongh-101981: Apply HOMEBREW related environment variables (python…
b57a039
…gh-102074)
@jaraco
Refactor zipfile._strip_extra to use higher level abstractions for ex…
8d9363b
…tras instead of a heavy-state loop.
@jaraco
jaraco requested review from abalkin, ezio-melotti, iritkatriel, markshannon and pganssle as code owners February 20, 2023 16:49
@bedevere-bot bedevere-bot added the awaiting core review label Feb 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 20, 2023
Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233
Closed
@jaraco jaraco closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@jaraco @bedevere-bot @thatch @mdickinson @rhettinger @erlend-aasland @zooba @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.