GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101819: Adapt _io types to heap types, batch 1 by erlend-aasland · Pull Request #101949 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

  • Issue: Isolate the _io extension module #101819

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland added 7 commits February 15, 2023 23:02
@erlend-aasland
Add tests
6d0a37b
@erlend-aasland
StringIO type
bd19a20
@erlend-aasland
PyTextIOWrapper type
9af73fe
@erlend-aasland
Move get_io_state() to main header
4bd73bd
@erlend-aasland
PyFileIO type
8d96a7a
@erlend-aasland
Buffered* types
97f382f
@erlend-aasland
PyBytesIO type
eeb5c48
@erlend-aasland erlend-aasland added the skip news label Feb 16, 2023
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 February 16, 2023 11:45
@bedevere-bot bedevere-bot added the awaiting core review label Feb 16, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 16, 2023
Isolate the _io extension module #101819
Closed
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit eeb5c48 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
erlend-aasland
erlend-aasland commented Feb 16, 2023
View reviewed changes
Comment thread Modules/_io/_iomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 5 commits February 16, 2023 12:51
@erlend-aasland
Remove unneded global state call
3c7e203
@erlend-aasland
Avoid PyState_FindModule as far as possible for now
254bfaf
@erlend-aasland
Fixup clinic_state for module level functions
b3db018
@erlend-aasland
Regen clinic
0570ae0
@erlend-aasland
Visit and clear heap types at module level
c1926a6
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 16, 2023 13:08
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit c1926a6 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
erlend-aasland added 2 commits February 16, 2023 14:20
@erlend-aasland
Fix tests on Windows
471ae9f
@erlend-aasland
Pull in main
345ffd3
@erlend-aasland
erlend-aasland marked this pull request as draft February 16, 2023 13:46
@erlend-aasland
Fix unused variable warning
65c0086
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 65c0086 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
@erlend-aasland
Merge branch 'main' into isolate-io/1-heap-types
39e0a89
@erlend-aasland

erlend-aasland commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

(Pulled in main to see if Eric's test_imp PR may fix the bots)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Merge branch 'main' into isolate-io/1-heap-types
86a6dbc
kumaraditya303
kumaraditya303 approved these changes Feb 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 19, 2023
kumaraditya303
kumaraditya303 reviewed Feb 19, 2023
View reviewed changes
Comment thread Modules/_io/textio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 19, 2023
@bedevere-bot

bedevere-bot commented Feb 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 86a6dbc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 19, 2023
@erlend-aasland
Merge branch 'main' into isolate-io/1-heap-types
cf1eb47
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 19, 2023 19:46
@erlend-aasland erlend-aasland added the 🤖 automerge label Feb 19, 2023
@miss-islington

miss-islington commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Let's wait until the macOS CI is healthy [on main] before landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits February 20, 2023 14:21
@erlend-aasland
Pull in main
7e0f327
@erlend-aasland
Use Py_DEBUG iso. NDEBUG
cf605e6
@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit c00faf7 into python:main Feb 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 20, 2023
@erlend-aasland
erlend-aasland deleted the isolate-io/1-heap-types branch February 20, 2023 13:51
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

We might have broken CI: https://buildbot.python.org/all/#/builders/729/builds/3820
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 20, 2023
@erlend-aasland @jaraco
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949
13882e0 
)

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

Automerge-Triggered-By: GH:erlend-aasland
@jaraco jaraco mentioned this pull request Feb 20, 2023
gh-88233: zipfile: refactor _strip_extra #102083
Closed
carljm added a commit to carljm/cpython that referenced this pull request Feb 20, 2023
@carljm
Merge branch 'main' into inlinecomp2
9f0fc5b 
* main: (60 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Feb 22, 2023
@carljm
Merge branch 'main' into inlinecomp
544b30c 
* main: (225 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@erlend-aasland @python-sidebar
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949
34e4ff2 
)

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

Automerge-Triggered-By: GH:erlend-aasland
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@erlend-aasland @python-sidebar
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949
575d8d0 
)

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @miss-islington @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.