GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101981: Apply HOMEBREW related environment variables by corona10 · Pull Request #102074 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: CI: intermittent macOS failures for make checksharedmods #101981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@corona10
pythongh-101981: Make macOS CI as same as dev-guide
f9dbbf5
@bedevere-bot bedevere-bot added the awaiting core review label Feb 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 20, 2023
CI: intermittent macOS failures for make checksharedmods #101981
Closed
@corona10
corona10 requested a review from erlend-aasland February 20, 2023 13:29
@corona10
corona10 marked this pull request as ready for review February 20, 2023 13:29
@corona10
corona10 requested a review from ezio-melotti as a code owner February 20, 2023 13:29
@corona10 corona10 added the skip news label Feb 20, 2023
corona10
corona10 commented Feb 20, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10 corona10 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 20, 2023
erlend-aasland
erlend-aasland requested changes Feb 20, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Feb 20, 2023
@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting changes label Feb 20, 2023
@corona10 @erlend-aasland
Update .github/workflows/build.yml
61b0e25
Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
erlend-aasland reviewed Feb 20, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 force-pushed the gh-101981-devguide branch from ed7e90d to b45a5a4 Compare February 20, 2023 13:35
@corona10
Address code review
0894d6f
@corona10
corona10 force-pushed the gh-101981-devguide branch from 4f85a4c to 0894d6f Compare February 20, 2023 13:37
erlend-aasland
erlend-aasland reviewed Feb 20, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

corona10 added 2 commits February 20, 2023 22:37
@corona10
Address code review
990c316
@corona10
Apply @hugovk's suggestion
cb01a13
@corona10
corona10 requested a review from hugovk February 20, 2023 13:40
erlend-aasland
erlend-aasland approved these changes Feb 20, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Feb 20, 2023
@erlend-aasland erlend-aasland changed the title gh-101981: Make macOS CI as same as dev-guide gh-101981: Combine macOS configure steps as recommended by the devguide Feb 20, 2023
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

This is nice!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes Feb 20, 2023
View reviewed changes
sobolevn
sobolevn reviewed Feb 20, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @corona10 and @erlend-aasland for fixing the CI 🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
Revert some changes
fa06ded
@corona10 corona10 removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 20, 2023
@corona10 corona10 changed the title gh-101981: Combine macOS configure steps as recommended by the devguide gh-101981: Apply HOMEBREW related environment variables. Feb 20, 2023
@corona10 corona10 changed the title gh-101981: Apply HOMEBREW related environment variables. gh-101981: Apply HOMEBREW related environment variables Feb 20, 2023
@corona10
corona10 merged commit ed01add into python:main Feb 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 20, 2023
@corona10
corona10 deleted the gh-101981-devguide branch February 20, 2023 15:20
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Why not backport this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10 corona10 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 20, 2023
@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

GH-102081 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2023
@corona10 @miss-islington
pythongh-101981: Apply HOMEBREW related environment variables (python…
fc6fd58
…gh-102074)

(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

GH-102082 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2023
@corona10 @miss-islington
pythongh-101981: Apply HOMEBREW related environment variables (python…
9652b51
…gh-102074)

(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 20, 2023
@corona10

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member Author

Why not backport this?

I thought that it could be a kind of new feature for the CI systems lol.
But after I read the comment from the @zooba at Discord, I change my mind about backporting this.

zooba and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request Feb 20, 2023
@miss-islington @corona10
gh-101981: Apply HOMEBREW related environment variables (gh-102074)
95f4e2c
(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Feb 20, 2023
@miss-islington @corona10
gh-101981: Apply HOMEBREW related environment variables (gh-102074)
1747be4
(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <[email protected]>
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 20, 2023
@corona10 @jaraco
pythongh-101981: Apply HOMEBREW related environment variables (python…
b57a039
…gh-102074)
@jaraco jaraco mentioned this pull request Feb 20, 2023
gh-88233: zipfile: refactor _strip_extra #102083
Closed
@AlexWaygood AlexWaygood mentioned this pull request Feb 20, 2023
Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installs python/typeshed#9713
Merged
carljm added a commit to carljm/cpython that referenced this pull request Feb 20, 2023
@carljm
Merge branch 'main' into inlinecomp2
9f0fc5b
* main: (60 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
@AlexWaygood AlexWaygood mentioned this pull request Feb 21, 2023
Add some more environment variables to speedup brew installs in CI python/typeshed#9786
Merged
carljm added a commit to carljm/cpython that referenced this pull request Feb 22, 2023
@carljm
Merge branch 'main' into inlinecomp
544b30c
* main: (225 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@corona10 @python-sidebar
pythongh-101981: Apply HOMEBREW related environment variables (python…
57cde1f
…gh-102074)
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@corona10 @python-sidebar
pythongh-101981: Apply HOMEBREW related environment variables (python…
38f9b35
…gh-102074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@corona10 @bedevere-bot @erlend-aasland @miss-islington @hugovk @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.