GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-102341: Improve the test function for pow by ppmfloss · Pull Request #102342 · python/cpython

Conversation

ppmfloss commented Feb 28, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Currently in the powtest function in Lib/test/test_pow.py file we are not testing the results of calling pow with negative exponents.
This PR will add appropriate assert statements to test the results of calling pow with negative exponents.

Issue: Improve the test function for pow #102341

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythonGH-102341: Improve the test function for pow

3bb233d

bedevere-bot added the awaiting review label

Feb 28, 2023

bedevere-bot mentioned this pull request

Feb 28, 2023

Improve the test function for pow #102341

Closed

bedevere-bot added the tests Tests in the Lib/test dir label

Feb 28, 2023


          Merge branch 'main' into fix-pow-test

bf53950

terryjreedy requested review from mdickinson and rhettinger

February 28, 2023 22:56

terryjreedy added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Feb 28, 2023

terryjreedy commented Feb 28, 2023

Copy link

Copy Markdown

Member

Mark and Raymond, a one-line addition to test_pow that looks plausible but I am not sure.

Pipelines win32 failure is unrelated of type seen before.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rhettinger removed their request for review

March 1, 2023 02:36

mdickinson commented Mar 1, 2023

Copy link

Copy Markdown

Member

Thanks for the ping, @terryjreedy. I'll take a look this weekend.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdickinson self-assigned this

Mar 1, 2023

AlexWaygood added the skip news label

Mar 2, 2023

mdickinson approved these changes

Mar 4, 2023

View reviewed changes

mdickinson left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we drop the for othertype in (int,): outer loop while we're here? (I'm guessing that it stems from Python 2 days, and was originally spelled for othertype in (int, long):.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 4, 2023

terryjreedy requested changes

Mar 4, 2023

View reviewed changes

Comment thread

Lib/test/test_pow.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_pow.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_pow.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting merge labels

Mar 4, 2023

terryjreedy added 3 commits

March 4, 2023 13:16


          Update Lib/test/test_pow.py

a47be96


          Update Lib/test/test_pow.py

b227f20


          Update Lib/test/test_pow.py

da9e411

python deleted a comment from bedevere-bot

Mar 4, 2023

terryjreedy commented Mar 4, 2023

Copy link

Copy Markdown

Member

Please recheck after deletion, dedent, and condensation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fix indentation spaces

a24b63d

ppmfloss commented Mar 4, 2023

Copy link

Copy Markdown

Contributor Author

I have removed some indentation spaces and retested it locally successfully.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into fix-pow-test

5135b45

mdickinson approved these changes

Mar 5, 2023

View reviewed changes

mdickinson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting changes label

Mar 5, 2023

bedevere-bot added the awaiting merge label

Mar 5, 2023

terryjreedy merged commit 3222054 into python:main

Mar 5, 2023

bedevere-bot removed the awaiting merge label

Mar 5, 2023

miss-islington commented Mar 5, 2023

Copy link

Copy Markdown

Contributor

Thanks @ppmfloss for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Mar 5, 2023

Copy link

Copy Markdown

GH-102446 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Mar 5, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 5, 2023


          pythonGH-102341: Improve the test function for pow (pythonGH-102342)

88a27b9

(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

bedevere-bot commented Mar 5, 2023

Copy link

Copy Markdown

GH-102447 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 5, 2023


          pythonGH-102341: Improve the test function for pow (pythonGH-102342)

70560bd

(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

bedevere-bot removed the needs backport to 3.10 label

Mar 5, 2023

miss-islington added a commit that referenced this pull request

Mar 5, 2023


          GH-102341: Improve the test function for pow (GH-102342)

9cec602

(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

miss-islington added a commit that referenced this pull request

Mar 5, 2023


          GH-102341: Improve the test function for pow (GH-102342)

db8d10b

(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>

hugovk pushed a commit to hugovk/cpython that referenced this pull request

Mar 6, 2023


          pythonGH-102341: Improve the test function for pow (python#102342)

7a07747

Co-authored-by: Terry Jan Reedy <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Mar 6, 2023


          Merge branch 'main' into nodeaddict

33dda2a

* main: (21 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

Mar 7, 2023


          Merge branch 'main' into inlinecomp2

ecb313c

* main: (37 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...

Reviewers

terryjreedy

terryjreedy requested changes

+1 more reviewer

mdickinson

mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

mdickinson

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ppmfloss commented Feb 28, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy commented Feb 28, 2023

Uh oh!

mdickinson commented Mar 1, 2023

Uh oh!

mdickinson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

terryjreedy commented Mar 4, 2023

Uh oh!

ppmfloss commented Mar 4, 2023

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Mar 5, 2023

Uh oh!

bedevere-bot commented Mar 5, 2023

Uh oh!

bedevere-bot commented Mar 5, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ppmfloss commented Feb 28, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

mdickinson left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.