GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-63301: Set exit code when tabnanny CLI exits on error by ultimatecoder · Pull Request #7699 · python/cpython

Conversation

ultimatecoder commented Jun 15, 2018 •

edited by erlend-aasland

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Setting appropriate exit code when tabnanny is exiting with errors. Occurrences of errprint under chec() are escaped with a reason to continue traversing files under a directory.

Issue: Add tests for CLI of the tabnanny module #63301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [IMPROVE] Setting appropriate exit code when is existing with erros.

2cfc30b

the-knights-who-say-ni added the CLA signed label

Jun 15, 2018

bedevere-bot added the awaiting review label

Jun 15, 2018

vstinner commented Jun 15, 2018

Copy link

Copy Markdown

Member

You didn't patch all calls to errprint(). Well, another approach is to put the exit() in errprint() directly.

Moreover, test_tabnanny fails.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti removed the CLA signed label

Jul 13, 2022


          Merge branch 'main' into master-tabnany-exit-code

3d12e35

erlend-aasland changed the title ~~bpo-19102: Setting appropriate exit code when "tabnanny" is existing with errors.~~ gh-7699: Setting appropriate exit code when "tabnanny" is existing with errors

Feb 1, 2023

erlend-aasland changed the title ~~gh-7699: Setting appropriate exit code when "tabnanny" is existing with errors~~ gh-7699: Set exit code when tabnanny CLI exits on error

Feb 1, 2023

erlend-aasland changed the title ~~gh-7699: Set exit code when tabnanny CLI exits on error~~ gh-63301: Set exit code when tabnanny CLI exits on error

Feb 1, 2023

erlend-aasland added 2 commits

February 1, 2023 10:40


          Address Victor's review

8582b30


          Add NEWS

0b8f830

hauntsaninja approved these changes

Feb 9, 2023

View reviewed changes

hauntsaninja left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks straightforward enough

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 9, 2023

arhadthedev reviewed

Feb 9, 2023

View reviewed changes

Comment thread

Lib/tabnanny.py

		sys.stderr.write(sep + str(arg))
		sep = " "
		sys.stderr.write("\n")
		sys.exit(1)

arhadthedev Feb 9, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the whole errprint() be replaced with this:

def errprint(*args):
    sys.exit(' '.join(str(arg) for arg in args))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hauntsaninja merged commit 8176334 into python:main

Mar 4, 2023

bedevere-bot removed the awaiting merge label

Mar 4, 2023

berkerpeksag mentioned this pull request

Apr 10, 2022

Add tests for CLI of the tabnanny module #63301

Closed

hauntsaninja commented Mar 4, 2023

Copy link

Copy Markdown

Contributor

Thank you Jaysinh and Erlend!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Mar 4, 2023

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 8176334.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/4607) and take a look at the build logs.
Check if the failure is related to this commit (8176334) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/4607

Failed tests:

test_subprocess

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

399 tests OK.

10 slowest tests:

test_math: 5 min 39 sec
test_multiprocessing_spawn: 4 min 31 sec
test_wmi: 3 min 46 sec
test_tokenize: 3 min 12 sec
test_asyncio: 2 min 26 sec
test_capi: 2 min 12 sec
test_lib2to3: 1 min 51 sec
test_concurrent_futures: 1 min 48 sec
test_unparse: 1 min 43 sec
test_mmap: 1 min 28 sec

35 tests skipped:
test_check_c_globals test_clinic test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_nis test_openpty
test_ossaudiodev test_peg_generator test_perf_profiler test_pipes
test_poll test_posix test_pty test_pwd test_readline test_resource
test_spwd test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64

1 re-run test:
test_subprocess

Total duration: 25 min 14 sec

Click to see traceback logs

remote: Enumerating objects: 11, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 11 (delta 2), reused 2 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out '81763341ede99ea5ae8993a57b8e3b71b46b2d72'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 8176334... gh-63301: Set exit code when tabnanny CLI exits on error (#7699)
Switched to and reset branch 'main'

Could Not Find D:\buildarea\3.x.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip

minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(50) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)

Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk pushed a commit to hugovk/cpython that referenced this pull request

Mar 6, 2023


          pythongh-63301: Set exit code when tabnanny CLI exits on error (pytho…

b70f49f

…n#7699)

Co-authored-by: Erlend E. Aasland <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Mar 6, 2023


          Merge branch 'main' into nodeaddict

33dda2a

* main: (21 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

Mar 7, 2023


          Merge branch 'main' into inlinecomp2

ecb313c

* main: (37 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...

Reviewers

arhadthedev

arhadthedev left review comments

hauntsaninja

hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ultimatecoder commented Jun 15, 2018 • edited by erlend-aasland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Jun 15, 2018

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

arhadthedev Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

hauntsaninja commented Mar 4, 2023

Uh oh!

bedevere-bot commented Mar 4, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ultimatecoder commented Jun 15, 2018 •

edited by erlend-aasland

Loading

Uh oh!

There was an error while loading. Please reload this page.