GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102939: Fix "conversion from Py_ssize_t to long" warning in builtins by sobolevn · Pull Request #102940 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since we now work with Py_size_t instead of long (see 7559f5f#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1) I've change the PyLong_ constructor.

  • Issue: New warnings in bltnsmodule.c: "conversion from 'Py_ssize_t' to 'long'" #102939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-102939: Fix "conversion from Py_ssize_t to long" warning in …
8fb27f1 
…builtins
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2023
New warnings in bltnsmodule.c: "conversion from 'Py_ssize_t' to 'long'" #102939
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 23, 2023
@sobolevn sobolevn added the skip news label Mar 23, 2023
@sobolevn

sobolevn commented Mar 23, 2023

Copy link
Copy Markdown
Member Author

Looks like the warning is gone! 🎉

I've opened a new issue about ‘subobj’ may be used uninitialized in this function [-Wmaybe-uninitialized]: #102941
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn mentioned this pull request Mar 23, 2023
GH-101291: Rearrange the size bits in PyLongObject #102464
Merged
@sobolevn
sobolevn requested a review from markshannon March 23, 2023 09:31
@sobolevn sobolevn mentioned this pull request Mar 23, 2023
gh-102941: Fix "‘subobj’ may be used uninitialized in this function" warning in bytes_methods.c #102942
Merged
markshannon
markshannon approved these changes Mar 23, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 23, 2023
@markshannon
markshannon merged commit 0f2ba65 into python:main Mar 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 23, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@sobolevn @Fidget-Spinner
pythongh-102939: Fix "conversion from Py_ssize_t to long" warning in …
c95d83c 
…builtins (pythonGH-102940)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @warsaw
pythongh-102939: Fix "conversion from Py_ssize_t to long" warning in …
681cc5f 
…builtins (pythonGH-102940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.