GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102941: Fix "‘subobj’ may be used uninitialized in this function" warning in `bytes_methods.c` by sobolevn · Pull Request #102942 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I still think that this warning is a false positive and there's no way to actually abuse it.
So, I hope that = NULL will just make it go away.

  • Issue: New warning: "‘subobj’ may be used uninitialized in this function" in Objects/bytes_methods.c #102941

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-102941: Fix "‘subobj’ may be used uninitialized in this func…
f360cec 
…tion" warning in `bytes_methods.c`
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2023
New warning: "‘subobj’ may be used uninitialized in this function" in Objects/bytes_methods.c #102941
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 23, 2023
@sobolevn sobolevn added the skip news label Mar 23, 2023
@sobolevn

sobolevn commented Mar 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The warning is gone 🎉
The second one is solved here: #102940

@kumaraditya303 can you please take a look? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn requested a review from kumaraditya303 March 23, 2023 10:05
@sobolevn

sobolevn commented Mar 24, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland can you please take a look? :)
All PRs get this warning, it is kinda annoying and might scare people.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

I'm travelling currently, please find another reviewer or wait till I'm back.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Mar 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 27, 2023
@JelleZijlstra
JelleZijlstra merged commit 2cdc518 into python:main Mar 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 27, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@sobolevn @Fidget-Spinner
pythongh-102941: Fix "‘subobj’ may be used uninitialized in this func…
0f312ec 
…tion" warning in `bytes_methods.c` (python#102942)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @warsaw
pythongh-102941: Fix "‘subobj’ may be used uninitialized in this func…
0e351ba 
…tion" warning in `bytes_methods.c` (python#102942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @kumaraditya303 @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.