GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103023: Add SyntaxError check in pdb's `display` command by gaogaotiantian · Pull Request #103024 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Mar 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In this PR, extra stuff was cleaned up a bit:

  1. sys.exc_info() is no longer needed now that format_exception_only supported exception object directly.
  2. A clearer message is sent to the users when no expression is being displayed
  • Issue: Add SyntaxError check for pdb's command display #103023

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jingxu94 and SeanXiaoby reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
gaogaotiantian added 2 commits March 24, 2023 18:57
@gaogaotiantian
Add syntax error check for display
3b362b0
@gaogaotiantian
Check if any expression is being displayed
484b882
@bedevere-bot bedevere-bot mentioned this pull request Mar 25, 2023
Add SyntaxError check for pdb's command display #103023
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 25, 2023
@blurb-it
📜🤖 Added by blurb_it.
52a1cbf
sunmy2019
sunmy2019 requested changes Mar 25, 2023
View reviewed changes
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 25, 2023
@gaogaotiantian
Use BaseException to catch all exceptions
a843f97
sunmy2019
sunmy2019 requested changes Mar 26, 2023
View reviewed changes
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
gaogaotiantian added 2 commits March 26, 2023 10:25
@gaogaotiantian
Add the syntax error message to output
b736697
@gaogaotiantian
Update test
9a9762a
sunmy2019
sunmy2019 approved these changes Mar 27, 2023
View reviewed changes
@ambv
Make the news entry more descriptive
c7810ff
@ambv
ambv merged commit 3606753 into python:main Mar 27, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 27, 2023
@gaogaotiantian
gaogaotiantian deleted the display-syntax-error branch March 27, 2023 21:16
@arhadthedev arhadthedev mentioned this pull request Mar 30, 2023
gh-103124: Multiline statement support for pdb #103125
Merged
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@gaogaotiantian @ambv @warsaw
pythongh-103023: Add SyntaxError check in pdb's display command (py…
6ddabe1 
…thon#103024)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunmy2019 sunmy2019 sunmy2019 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gaogaotiantian @sunmy2019 @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.