GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103124: Multiline statement support for pdb by gaogaotiantian · Pull Request #103125 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented Mar 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fails one test now - the one that expects

(Pdb) print(

to fail directly. That's a behavior that the feature changes, so if we want to have this feature, we need to change the test.

  • Issue: Support multi-line statements in pdb #103124

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gaogaotiantian added 2 commits March 29, 2023 23:32
@gaogaotiantian
Draft for pdb multiline support
a326c24
@gaogaotiantian
Do not use actual line number for the test
3684e3a
@bedevere-bot bedevere-bot mentioned this pull request Mar 30, 2023
Support multi-line statements in pdb #103124
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 30, 2023
@arhadthedev arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Mar 30, 2023
@arhadthedev

arhadthedev commented Mar 30, 2023

Copy link
Copy Markdown
Member

@iritkatriel @ambv as mergers of related gh-101674 and gh-103024.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gaogaotiantian and others added 2 commits April 8, 2023 20:52
@gaogaotiantian
Add test for multiline statement
2dcfce7
@blurb-it
📜🤖 Added by blurb_it.
5aeb19d
@gaogaotiantian
gaogaotiantian marked this pull request as ready for review April 9, 2023 03:55
@brandtbucher
brandtbucher self-requested a review April 28, 2023 17:49
brandtbucher
brandtbucher reviewed May 10, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited to see this in 3.13! I'm just having a little trouble following the new logic (I believe you that it's correct, though):

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher brandtbucher self-assigned this Jun 15, 2023
@brandtbucher
brandtbucher enabled auto-merge (squash) June 15, 2023 23:00
@brandtbucher
brandtbucher disabled auto-merge June 15, 2023 23:00
@brandtbucher
brandtbucher enabled auto-merge (squash) June 15, 2023 23:01
@brandtbucher
Merge branch 'main' into pdb-multiline-statement
854b3e9
@brandtbucher
brandtbucher merged commit 25a64fd into python:main Jun 15, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jun 15, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@gaogaotiantian @gvanrossum
pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
860c007
@gaogaotiantian
gaogaotiantian deleted the pdb-multiline-statement branch May 6, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gaogaotiantian @arhadthedev @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.