GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103092: Isolate msvcrt by aisk · Pull Request #103248 · python/cpython

Conversation

@aisk

@aisk aisk commented Apr 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk
pythongh-103092: isolate msvcrt
a848eaa
@aisk
aisk requested a review from a team as a code owner April 4, 2023 16:07
@bedevere-bot bedevere-bot added the awaiting review label Apr 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 4, 2023
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
arhadthedev
arhadthedev reviewed Apr 5, 2023
View reviewed changes
Comment thread PC/msvcrtmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aisk @arhadthedev
Update PC/msvcrtmodule.c
bc8aa95 
Co-authored-by: Oleg Iarygin <[email protected]>
@erlend-aasland
erlend-aasland self-requested a review April 8, 2023 19:48
erlend-aasland
erlend-aasland reviewed Apr 8, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-04-04-21-44-25.gh-issue-103092.Dz0_Xn.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread PC/msvcrtmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread PC/msvcrtmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I'd like to land these first:

  • gh-83004: Harden msvcrt init #103383
  • gh-83004: Harden msvcrt further #103420
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title gh-103092: isolate msvcrt gh-103092: Isolate msvcrt Apr 8, 2023
aisk and others added 5 commits April 9, 2023 13:05
@aisk @erlend-aasland
Update Misc/NEWS.d/next/Library/2023-04-04-21-44-25.gh-issue-103092.D…
8dd469f 
…z0_Xn.rst

Co-authored-by: Erlend E. Aasland <[email protected]>
@aisk @erlend-aasland
Update PC/msvcrtmodule.c
cdc37b7 
Co-authored-by: Erlend E. Aasland <[email protected]>
@aisk @erlend-aasland
Update PC/msvcrtmodule.c
6119c5b 
Co-authored-by: Erlend E. Aasland <[email protected]>
@aisk
fix error branch in exec_module
b3f5edb
@erlend-aasland
Merge branch 'main' into isolate-msvcrt
cb96632
@erlend-aasland

This comment was marked as outdated.

Sign in to view
erlend-aasland and others added 2 commits April 10, 2023 21:30
@erlend-aasland
Fix merge
49d91e1
@aisk
Merge branch 'main' into isolate-msvcrt
8663d62
erlend-aasland
erlend-aasland approved these changes Apr 12, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 12, 2023
@erlend-aasland
erlend-aasland merged commit dce2d38 into python:main Apr 12, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 12, 2023
@erlend-aasland

erlend-aasland commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Thanks, @aisk.
aisk reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk
aisk deleted the isolate-msvcrt branch April 12, 2023 11:54
aisk added a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@aisk
pythongh-103092: Isolate msvcrt (python#103248)
21ceaf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aisk @erlend-aasland @arhadthedev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.