GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Harden msvcrt further by erlend-aasland · Pull Request #103420 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 10, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2023
Improve stdlib module initialization error handling. #83004
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 10, 2023
@erlend-aasland erlend-aasland mentioned this pull request Apr 10, 2023
gh-83004: Harden msvcrt init #103383
Merged
@erlend-aasland erlend-aasland added the skip news label Apr 10, 2023
@erlend-aasland
erlend-aasland force-pushed the harden-msvcrt-even-more branch from 02f8970 to cb9ff82 Compare April 10, 2023 19:09
@erlend-aasland

erlend-aasland commented Apr 10, 2023

Copy link
Copy Markdown
Contributor Author

The old insert* helpers were buggy: conversion errors were cleared, insert dict errors simply ignored (could theoretically end up overwriting the previous exception over and over again).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
pythongh-83004: Harden msvcrt further
88bb327
@erlend-aasland
erlend-aasland force-pushed the harden-msvcrt-even-more branch from cb9ff82 to 88bb327 Compare April 10, 2023 19:22
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 April 10, 2023 19:24
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 10, 2023 20:00
@erlend-aasland
erlend-aasland requested a review from a team as a code owner April 10, 2023 20:00
@erlend-aasland erlend-aasland mentioned this pull request Apr 10, 2023
gh-103092: Isolate msvcrt #103248
Merged
@erlend-aasland
Make the diff slightly nicer
6c1f145
@erlend-aasland
erlend-aasland requested a review from zooba April 12, 2023 08:39
erlend-aasland added 2 commits April 12, 2023 10:41
@erlend-aasland
Merge branch 'main' into harden-msvcrt-even-more
93df440
@erlend-aasland
Pull in main
1dcfc4f
kumaraditya303
kumaraditya303 reviewed Apr 18, 2023
View reviewed changes
Comment thread PC/msvcrtmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
Update PC/msvcrtmodule.c
9ff5c3f
kumaraditya303
kumaraditya303 requested changes Apr 18, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing error label

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Apr 18, 2023
@bedevere-bot

bedevere-bot commented Apr 18, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 3 commits April 18, 2023 13:11
@erlend-aasland
Pull in main
64efb42
@erlend-aasland
Intermingled declaration
b058d09
@erlend-aasland
Adress review: Return -1 iso. goto error
1f2162b
@erlend-aasland

erlend-aasland commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

missing error label

Thanks for the heads-up. I removed those gotos. PTAL.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland requested a review from kumaraditya303 April 18, 2023 19:13
kumaraditya303
kumaraditya303 approved these changes Apr 19, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Apr 19, 2023
@erlend-aasland
erlend-aasland merged commit bd2ed06 into python:main Apr 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 19, 2023
@erlend-aasland
erlend-aasland deleted the harden-msvcrt-even-more branch April 19, 2023 14:16
carljm added a commit to carljm/cpython that referenced this pull request Apr 20, 2023
@carljm
Merge branch 'main' into superopt
5c0a21c
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.