GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103088: Fix scripts for Windows by Zabolekar · Pull Request #103325 · python/cpython

Conversation

@Zabolekar

@Zabolekar Zabolekar commented Apr 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Zabolekar added 2 commits April 6, 2023 11:55
@Zabolekar
Allow using existing 3.11 install for PCbuild
ff776a6
@Zabolekar
Sanitize Windows paths when using MSYS or Cygwin
39c9d64
@Zabolekar
Zabolekar requested review from a team and vsajip as code owners April 6, 2023 23:09
@bedevere-bot

bedevere-bot commented Apr 6, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot mentioned this pull request Apr 6, 2023
If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 6, 2023
@ghost

ghost commented Apr 6, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev arhadthedev added OS-windows stdlib Standard Library Python modules in the Lib/ directory labels Apr 7, 2023
@blurb-it
📜🤖 Added by blurb_it.
a2d3a83
zooba
zooba reviewed Apr 11, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2023-04-11-09-22-22.gh-issue-103088.6AJEuR.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Zabolekar @zooba
Remove unneeded NEWS entry after review
4717c2c
Co-authored-by: Steve Dower <[email protected]>
@zooba
zooba merged commit ebc8103 into python:main Apr 11, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Apr 11, 2023
@Zabolekar
Zabolekar deleted the fix-windows-scripts-issue-103088 branch April 11, 2023 20:01
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@Zabolekar @aisk
pythongh-103088: Sanitize venv paths when using MSYS or Cygwin Bash (p…
94ce541
…ythonGH-103325)
@zware zware mentioned this pull request Apr 21, 2023
The activate script in Windows is not correct for venvs created in git-bash #82764
Closed
@rdbisme

rdbisme commented Jun 26, 2023

Copy link
Copy Markdown

Can we cut another release (I'm interested for Python 3.10) that includes this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pfmoore

pfmoore commented Jun 26, 2023

Copy link
Copy Markdown
Member

No, sorry, Python 3.10 is now in security fix only mode - see the release schedule.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rdbisme

rdbisme commented Oct 10, 2023

Copy link
Copy Markdown

@zooba any chance we might backport this to 3.11? We're 1 version behind at work, and forced to use windows, and while using Git bash or Msys and creating venvs, doing python -m pip install <something> with a venv activated installs the packages in the main python site-packages instead.

I'd appreciate for it to work as expected :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Oct 31, 2023

Copy link
Copy Markdown
Member

Backporting to 3.11 is probably okay, but we need a new PR without the additional change to the batch file.

If you (or someone else) creates one, target 3.11 and put [3.11] at the start of the PR name and (GH-103325) at the end.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jun 7, 2026
venv: Activation in fish inside msys2 (or similar) breaks PATH #151042
Closed
gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows #151043
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Zabolekar @bedevere-bot @rdbisme @pfmoore @zooba @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.