GeezerVison

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vsajip @FFY00 the equivalent PR was merged in both uv and virtualenv if you would like to compare for review :)

This patch and the virtualenv patch have

if string match -qr 'CYGWIN|MSYS|MINGW' (uname)

whereas the uv patch has

if string match -qr 'CYGWIN|MSYS|MINGW' (uname); and command -s cygpath >/dev/null

Isn't the more stringent check needed? Under CYGWIN one might expect cygpath to be available, but is it guaranteed to be present under MSYS/MINGW?

This patch and the virtualenv patch have

if string match -qr 'CYGWIN|MSYS|MINGW' (uname)

whereas the uv patch has

if string match -qr 'CYGWIN|MSYS|MINGW' (uname); and command -s cygpath >/dev/null

Isn't the more stringent check needed? Under CYGWIN one might expect cygpath to be available, but is it guaranteed to be present under MSYS/MINGW?

@vsajip, it's not necessary. MSYS2 ships the Cygwin tool cygpath by default. MinGW as an environment requires MSYS2 to be installed. The codebase also uses cygpath unguarded at several points thus indicating that it is a requirement.

It's fine to add a guard clause as the uv devs requested, I don't see how it could hurt, but its also not required.