GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix old behaviour in typing documentation by Gobot1234 · Pull Request #103400 · python/cpython

Conversation

@Gobot1234

@Gobot1234 Gobot1234 commented Apr 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor 
>>> class Z(Generic[T, P]): ...
... 
>>> Z[int, [dict, float]]
__main__.Z[int, [dict, float]]

Related to #102637

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Gobot1234
Fix old behaviour in documentation
987dbed 
>>> class Z(Generic[T, P]): ...
... 
>>> Z[int, [dict, float]]
__main__.Z[int, [dict, float]]
@Gobot1234
Gobot1234 requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners April 9, 2023 20:14
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 9, 2023
@AlexWaygood AlexWaygood added skip issue topic-typing needs backport to 3.11 only security fixes labels Apr 9, 2023
@Gobot1234

Gobot1234 commented Apr 9, 2023

Copy link
Copy Markdown
Contributor Author

Should this be backported to 3.11? It doesn't look like the original fix was
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Apr 9, 2023

Copy link
Copy Markdown
Member

Good point
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Apr 9, 2023
AlexWaygood
AlexWaygood approved these changes Apr 9, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change it so that these REPL snippets are actually run as part of CPython's doctest suite. But that can wait.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 9, 2023
@AlexWaygood
AlexWaygood merged commit ecad802 into python:main Apr 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 9, 2023
@Gobot1234
Gobot1234 deleted the patch-1 branch April 9, 2023 22:12
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@Gobot1234 @warsaw
Fix old behaviour in typing documentation (python#103400)
c798fd7
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@Gobot1234 @aisk
Fix old behaviour in typing documentation (python#103400)
fec2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Gobot1234 @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.