GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — gh-102615: Use `list` instead of `tuple` in `repr` of paramspec by sobolevn · Pull Request #102637 · python/cpython Conversation
|
|
I'm -1 on this fix. There is a bigger underlying issue. See #102615 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have no idea what to do here, I defer to @Fidget-Spinner. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm now +1 on this approach after Nikita reminded me that ParamSpec intentionally has edge cases that we cant fix. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR should be reviewed after #102681 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@AlexWaygood you can review this whenever you have the time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@AlexWaygood you can review this whenever you have the time.
Time, the most precious commodity of our age! Here's a review for the tests and docs :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, at least as a short-term fix.
I don't think we should backport this, as it could easily break people's doctests. Let me know if you disagree :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| TsP[int, str, list[int], []]: "TsP[int, str, list[int], []]", | ||
| TsP[int, [str, list[int]]]: "TsP[int, [str, list[int]]]", | ||
|
|
||
| # These lines are just too long to fit: |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
😆
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@sobolevn, should we make the same changes we made here to cpython/Lib/_collections_abc.py Line 515 in 51d693c
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
In fact... I wonder if we should just import |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@AlexWaygood I thought about making the similar change in Right now users can define their own classes with Any examples where this might be useful? I also think that sharing implementation details (functions starting with |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Okay, those are all good points. I think it might be nice at least to update the docstring of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I will! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…python#102637) Co-authored-by: Alex Waygood <[email protected]>
…python#102637) Co-authored-by: Alex Waygood <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.