GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103180: Add CI timeouts to all GitHub Actions jobs by sobolevn · Pull Request #103437 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See #103180 (comment) on why I used the numbers I used.

Docs: https://docs.github.com/ru/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

  • Issue: Add a timeout to CI builds #103180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-103180: Add CI timeouts to all GtiHub Actions jobs
66f638f
@sobolevn
sobolevn requested review from ezio-melotti and hugovk as code owners April 11, 2023 09:22
@bedevere-bot bedevere-bot mentioned this pull request Apr 11, 2023
Add a timeout to CI builds #103180
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 11, 2023
@sobolevn sobolevn added skip news build The build process and cross-build labels Apr 11, 2023
@sobolevn sobolevn changed the title gh-103180: Add CI timeouts to all GtiHub Actions jobs gh-103180: Add CI timeouts to all GitHub Actions jobs Apr 11, 2023
hugovk
hugovk approved these changes Apr 11, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the analysis at #103180 (comment).

We could probably skip timeouts for the short ones: timeouts tend to occur in the more complex and therefore slower ones, but I'm also fine adding them just in case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 11, 2023
@Ismaelkadir

This comment was marked as spam.

Sign in to view
@sobolevn

sobolevn commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

@Ismaelkadir sorry, I don't understand your message :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Ismaelkadir

This comment was marked as spam.

Sign in to view
hauntsaninja
hauntsaninja approved these changes Apr 14, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@hugovk
hugovk merged commit be8903e into python:main Apr 14, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 14, 2023
@hugovk hugovk added the needs backport to 3.11 only security fixes label Apr 14, 2023
@miss-islington

miss-islington commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker be8903eb9d66ef1229f93a3a6036aeafc3bb0bda 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk Apr 14, 2023
@sobolevn

sobolevn commented Apr 14, 2023

Copy link
Copy Markdown
Member Author

Do you want me to backport this to 3.11 as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Apr 14, 2023

Copy link
Copy Markdown
Member

Yes please, could be useful there too :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
@carljm
Merge branch 'main' into superopt
64da49f 
* main:
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 14, 2023
@sobolevn
[3.11] pythongh-103180: Add CI timeouts to all GitHub Actions jobs (p…
f7e8ca1 
…ythonGH-103437).

(cherry picked from commit be8903e)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 14, 2023

Copy link
Copy Markdown

GH-103543 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 14, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
@carljm
Merge branch 'superopt' into superopt_spec
b73cff0 
* superopt:
  fix incompatible types
  update generated cases
  don't unnecessarily re-find args in error case
  Apply suggestions from code review
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
hugovk pushed a commit that referenced this pull request Apr 15, 2023
@sobolevn
[3.11] gh-103180: Add CI timeouts to all GitHub Actions jobs (GH-103437…
a3242c7 
…). (#103543)
@hugovk hugovk mentioned this pull request Apr 20, 2023
[3.10] CI: Do not allow merge if labelled DO-NOT-MERGE (GH-103337) #103641
Closed
@AA-Turner AA-Turner mentioned this pull request Feb 20, 2025
GH-103180: Set a timeout for every job in GitHub Actions #130375
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @Ismaelkadir @miss-islington @hugovk @bedevere-bot @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.