GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-103180: Set a timeout for every job in GitHub Actions by AA-Turner · Pull Request #130375 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Feb 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As a half-workaround to GHA job hangs, this sets an explicit timeout on every job, meaning that it can be restarted after a sane period, rather than the default 6 hour (360 minute) allowance. This has a marginal benefit of freeing up CI resource quicker on such hangs, as we fail far sooner.

I've also standardised job names to use hyphens instead of the current mix of underscores and dashes, and made the order of inputs more consistent in a couple of cases.

Most notably, this means that if the required 'Check whether the needed jobs succeeded or failed' job hangs/fails, it can be restarted in 5 minutes, rather than pushing an empty commit or closing/reopening and triggering the full test suite again.

A

See also:

  • gh-103180: Add CI timeouts to all GitHub Actions jobs #103437
  • Add a timeout to CI builds #103180
  • Issue: Add a timeout to CI builds #103180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner
Set a timeout for every GitHub Actions job
c7f327a
@AA-Turner
AA-Turner requested a review from terryjreedy February 20, 2025 18:36
@AA-Turner
AA-Turner requested review from brandtbucher, ezio-melotti, hugovk and savannahostrowski as code owners February 20, 2025 18:36
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 20, 2025
@AA-Turner AA-Turner changed the title Set a timeout for every GitHub Actions job Set a timeout for every job in GitHub Actions Feb 20, 2025
AA-Turner
AA-Turner commented Feb 20, 2025
View reviewed changes
Comment thread .github/workflows/jit.yml
name: Free-Threaded (Debug)
needs: interpreter
runs-on: ubuntu-24.04
timeout-minutes: 90

@AA-Turner AA-Turner Feb 20, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note 90 minutes used here rather than 60, for consistency with the other two JIT jobs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner AA-Turner added skip issue skip news and removed skip issue labels Feb 20, 2025
@AA-Turner AA-Turner changed the title Set a timeout for every job in GitHub Actions GH-103180: Set a timeout for every job in GitHub Actions Feb 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2025
Add a timeout to CI builds #103180
Closed
zware
zware approved these changes Feb 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 20, 2025
@AA-Turner
Use source order in all-required-green lists
a6564de
@terryjreedy

terryjreedy commented Feb 21, 2025

Copy link
Copy Markdown
Member

I am not familiar with .yml, but definitely approve of the goal.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 21, 2025
hugovk
hugovk approved these changes Feb 21, 2025
View reviewed changes
ezio-melotti
ezio-melotti approved these changes Feb 21, 2025
View reviewed changes
@hugovk
hugovk merged commit d0a1e5c into python:main Feb 21, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 21, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 21, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 21, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d0a1e5c222f9f43b492b28806e2a185a50d64500 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned hugovk Feb 21, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 21, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d0a1e5c222f9f43b492b28806e2a185a50d64500 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
AA-Turner deleted the gha-timeout branch February 21, 2025 15:16
@hugovk

hugovk commented Feb 21, 2025

Copy link
Copy Markdown
Member

@AA-Turner Please could you do the backports?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Feb 21, 2025

Copy link
Copy Markdown
Member Author

I think we need the other backports merged first, then Miss Islington might work?

A

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Feb 21, 2025

Copy link
Copy Markdown
Member

Please could you check #130367? Then let's retry.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 22, 2025
@AA-Turner
[3.13] pythonGH-103180: Set a timeout for every job in GitHub Actions (…
06ecbf1
…pythonGH-130375)

(cherry picked from commit d0a1e5c)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130431 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 22, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 22, 2025
@AA-Turner
[3.12] pythonGH-103180: Set a timeout for every job in GitHub Actions (…
1c3e33c
…pythonGH-130375)

(cherry picked from commit d0a1e5c)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130432 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 22, 2025
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@AA-Turner
[3.12] GH-103180: Set a timeout for every job in GitHub Actions (GH-1…
59c3eb4
…30375) (#130432)

(cherry picked from commit d0a1e5c)
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@AA-Turner
[3.13] GH-103180: Set a timeout for every job in GitHub Actions (GH-1…
9dd2cb7
…30375) (#130431)

(cherry picked from commit d0a1e5c)
@AA-Turner

AA-Turner commented Feb 22, 2025

Copy link
Copy Markdown
Member Author

@AA-Turner Please could you do the backports?

Backports (eventually....) done

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@zware zware zware approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @terryjreedy @hugovk @zware @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.