GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103553: Improve `test_inspect`: add more assertions, remove unused by sobolevn · Pull Request #103554 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This cleanup is quite straight-forward :)

  • Issue: Improve test_inspect #103553

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-103553: Improve test_inspect: add more assertions, remove …
4c3f7e2 
…unused
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 15, 2023
Improve test_inspect #103553
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 15, 2023
@sobolevn sobolevn added the skip news label Apr 15, 2023
jacobtylerwalls
jacobtylerwalls approved these changes Apr 15, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 15, 2023
Ismaelkadir
Ismaelkadir approved these changes Apr 15, 2023
View reviewed changes
@Ismaelkadir

Ismaelkadir commented Apr 15, 2023

Copy link
Copy Markdown

Merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Apr 15, 2023

Copy link
Copy Markdown
Member Author

@Ismaelkadir Hi! :)

I see that you've just joined GitHub and you take interest in CPython's development.
Please, let me introduce you with out development guides: https://devguide.python.org/

There you can see how we do code reviews and how, who, and when merge PRs.

Please, feel free to ask any question you have about the process.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja
hauntsaninja approved these changes Apr 15, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 15, 2023
@hauntsaninja hauntsaninja added needs backport to 3.11 only security fixes awaiting merge and removed awaiting merge labels Apr 15, 2023
@hauntsaninja
hauntsaninja merged commit 4fe1c4b into python:main Apr 15, 2023
@miss-islington

miss-islington commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2023
@sobolevn @miss-islington
pythongh-103553: Improve test_inspect: add more assertions, remove …
7a6d6dc 
…unused (pythonGH-103554)

(cherry picked from commit 4fe1c4b)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 15, 2023

Copy link
Copy Markdown

GH-103568 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 15, 2023
miss-islington added a commit that referenced this pull request Apr 15, 2023
@miss-islington @sobolevn
gh-103553: Improve test_inspect: add more assertions, remove unused (…
9f3f109 
…GH-103554)

(cherry picked from commit 4fe1c4b)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn sobolevn mentioned this pull request Apr 16, 2023
gh-103556: [inspect.Signature] disallow pos-or-kw params without default after pos-only with default #103557
Merged
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
@carljm
Merge branch 'main' into superopt
5136459 
* main:
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
@carljm
Merge branch 'superopt' into superopt_spec
079c65a 
* superopt:
  update generated cases with new comment
  review comments
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
+2 more reviewers
@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes
@Ismaelkadir Ismaelkadir Ismaelkadir approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @Ismaelkadir @miss-islington @bedevere-bot @hauntsaninja @jacobtylerwalls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.