GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove `expert-*` from `project-updater` GH workflow by ezio-melotti · Pull Request #103579 · python/cpython

Conversation

@ezio-melotti

@ezio-melotti ezio-melotti commented Apr 16, 2023

Copy link
Copy Markdown
Member

The expert-* labels are being renamed to topic-*, breaking the project-updater workflow. In the meanwhile GitHub also added a project workflow to automatically add issues (and PRs) to a project, that might be used to replace the workflow entirely.

I now updated both the Subinterpreters and Asyncio projects and enable to auto-add workflow, so we can safely remove them from here. Eventually we might get rid of the workflow altogether.

See:

  • python/cpython labels grouping core-workflow#450 (comment)
  • https://discuss.python.org/t/lets-rename-expert-labels-to-something-more-welcoming/24826
  • https://github.blog/changelog/2023-03-09-github-issues-projects-march-9th-update/#robot-automatically-add-and-archive-project-items

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ezio-melotti
Remove expert-* from project-updater GH workflow
10fdafd 
The `expert-*` labels are being renamed and the project workflow can now be used to auto-add issues to projects, so they can be removed from here.
@ezio-melotti ezio-melotti added skip issue skip news 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes 3.13 only security fixes labels Apr 16, 2023
@ezio-melotti
ezio-melotti requested a review from hugovk as a code owner April 16, 2023 17:29
@ezio-melotti ezio-melotti self-assigned this Apr 16, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Apr 16, 2023
@ezio-melotti ezio-melotti mentioned this pull request Apr 16, 2023
python/cpython labels grouping python/core-workflow#450
Closed
@sobolevn sobolevn mentioned this pull request Apr 16, 2023
Test issue #103580
Closed
sobolevn
sobolevn approved these changes Apr 16, 2023
View reviewed changes

@sobolevn sobolevn left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that everything works without these lines: I've opened a test issue #103580

It was correctly handled.
Снимок экрана 2023-04-16 в 21 02 01
Снимок экрана 2023-04-16 в 21 02 29

Thank you! 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk approved these changes Apr 17, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 17, 2023
@hugovk
hugovk merged commit 76933df into main Apr 17, 2023
@miss-islington

miss-islington commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @ezio-melotti for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 17, 2023
@miss-islington

miss-islington commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ezio-melotti and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 76933df10afc958b2db2a6bcff7509285fbf5fcf 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk and unassigned ezio-melotti Apr 17, 2023
@ezio-melotti
ezio-melotti deleted the remove-expert-labels branch April 17, 2023 03:33
@hugovk

hugovk commented Apr 17, 2023

Copy link
Copy Markdown
Member

There's no .github/workflows/project-updater.yml in the 3.11 branch:

https://github.com/python/cpython/tree/main/.github/workflows
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed 3.11 only security fixes needs backport to 3.11 only security fixes labels Apr 17, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
@carljm
Merge branch 'main' into superopt
5136459 
* main:
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
@carljm
Merge branch 'superopt' into superopt_spec
079c65a 
* superopt:
  update generated cases with new comment
  review comments
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

3.12 only security fixes 3.13 only security fixes skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ezio-melotti @miss-islington @hugovk @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.