GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103583: Add ref. dependency between multibytecodec modules by erlend-aasland · Pull Request #103589 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The cjk codec modules now always outlive _multibytecodec

  • Issue: Isolate _multibytecodec #103583

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
erlend-aasland added 3 commits April 17, 2023 07:58
@erlend-aasland
Add capsule wrapper for codecs
631c912
@erlend-aasland
Put a reference to the cjk module into the codec capsule
bdcfe44
@erlend-aasland
Make MultibyteCodecObject own a reference to the codec module that ow…
e376c47
…ns its codec memory
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner April 17, 2023 14:00
@bedevere-bot bedevere-bot mentioned this pull request Apr 17, 2023
Isolate _multibytecodec #103583
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 17, 2023
@erlend-aasland erlend-aasland added the skip news label Apr 17, 2023
@erlend-aasland

erlend-aasland commented Apr 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Depends on:

  • gh-103583: Always pass multibyte codec structs as const #103588
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland mentioned this pull request Apr 17, 2023
gh-103583: Always pass multibyte codec structs as const #103588
Merged
@erlend-aasland

erlend-aasland commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

For the record, PyMultibyteCodec_CAPSULE_NAME is not exposed through Python.h:

$ echo '#include "Python.h"' | gcc -E $(./python.exe ./python-config.py --includes) - | grep PyMultibyteCodec_CAPSULE_NAME
$
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 19, 2023
@bedevere-bot

bedevere-bot commented Apr 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit e376c47 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 19, 2023
@corona10

corona10 commented Apr 19, 2023

Copy link
Copy Markdown
Member

@erlend-aasland Please rebase the PR, I will review the PR by tomorrow :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, I will :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
Pull in main
8372d65
@erlend-aasland

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

Ref. leak bots passed all green. Pulling in main now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

@corona10, ready for your second review :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10
corona10 approved these changes Apr 19, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, patch itself looks pretty straightforward :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 19, 2023
@erlend-aasland
erlend-aasland merged commit a6b07b5 into python:main Apr 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 19, 2023
@erlend-aasland
erlend-aasland deleted the cjk-ref-dependency branch April 19, 2023 16:02
carljm added a commit to carljm/cpython that referenced this pull request Apr 20, 2023
@carljm
Merge branch 'main' into superopt
5c0a21c
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
@erlend-aasland erlend-aasland mentioned this pull request Apr 26, 2023
gh-103583: Isolate CJK codec modules #103869
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @bedevere-bot @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.