GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-103903: Test the minimum Sphinx version in CI by AA-Turner · Pull Request #103904 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Test documentation with the oldest supported Sphinx version #103903

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 4 commits April 26, 2023 23:40
@AA-Turner
Add ability to select requirements file in make venv
a5ccb71
@AA-Turner
Fix cross-referencing problems for Sphinx 3.2
4ffce8d
@AA-Turner
Add requirements file for Sphinx 3.2
e0d9ad8
@AA-Turner
Add new 'oldest sphinx' docs workflow
d3bec57
@AA-Turner
AA-Turner requested review from berkerpeksag, erlend-aasland, ezio-melotti and hugovk as code owners April 26, 2023 22:56
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Test documentation with the oldest supported Sphinx version #103903
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 26, 2023
@AA-Turner
AA-Turner requested review from AlexWaygood and CAM-Gerlach and removed request for berkerpeksag and erlend-aasland April 26, 2023 22:56
@erlend-aasland
erlend-aasland requested review from berkerpeksag and removed request for AlexWaygood and CAM-Gerlach April 26, 2023 22:57
AA-Turner added 2 commits April 26, 2023 23:58
@AA-Turner
Clarify note in r-o-s
299f52f
@AA-Turner
re-order list
558ff51
@AA-Turner AA-Turner added docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news labels Apr 26, 2023
@AA-Turner AA-Turner mentioned this pull request Apr 26, 2023
GH-99380: Update to Sphinx 7 #99381
Merged
@AA-Turner

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland -- were you just removing your own automatic review request, or did you mean to remove Alex & Cam too? The interface says we both edited at the same time so I wonder if there was clash -- just checking intentionality!

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Apr 26, 2023

Copy link
Copy Markdown
Member

(I'm happy to review, but have just boarded the first of two flights back to the UK, so my review might be a little delayed! :)
AA-Turner and erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

Safe journey!
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

I only meant to remove myself. I don't know anything about the various Sphinx versions, sorry. I'm sure both CAM and Alex are much more competent reviewers than me, for this PR.
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Apr 27, 2023
View reviewed changes
Comment thread .github/workflows/doc.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/doc.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Apr 27, 2023

Copy link
Copy Markdown
Member

(I'm happy to review, but have just boarded the first of two flights back to the UK, so my review might be a little delayed! :)

Excuses, excuses! ;) Welcome home!
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I only meant to remove myself. I don't know anything about the various Sphinx versions, sorry.

No worries, I just wanted to check lest you'd had discussions in person!

A
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner requested a review from AlexWaygood April 27, 2023 12:42
@AA-Turner
Re-arrange
5a1ae9a
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!
erlend-aasland, hugovk, and AlexWaygood reacted with laugh emoji
All reactions
  • 😄 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting review labels Apr 27, 2023
@bedevere-bot

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

Oh, does Sir Bedevere not recognise a regular 'comment' review?

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Apr 27, 2023
View reviewed changes

@hugovk hugovk left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, does Sir Bedevere not recognise a regular 'comment' review?

PR looks good now, but just testing this out... Want to try it again?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

Same result -- I'd guess that he picks up the key-phrase but doesn't recognise who to ping for a re-review?

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Apr 27, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks @AA-Turner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Apr 27, 2023
@AlexWaygood
AlexWaygood merged commit 44b5c21 into python:main Apr 27, 2023
@miss-islington

miss-islington commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 27, 2023
@miss-islington

miss-islington commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 44b5c21f4124f9fa1312fada313c80c6abfa6d49 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned AlexWaygood Apr 27, 2023
@AlexWaygood

AlexWaygood commented Apr 27, 2023

Copy link
Copy Markdown
Member

@AA-Turner, can I leave the backport in your capable hands? :)
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

@AA-Turner, can I leave the backport in your capable hands? :)

Yessir, just having dinner though -- will do later this eve!

A
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood assigned AA-Turner and unassigned AlexWaygood Apr 27, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
@AA-Turner
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
5359efe 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
@AA-Turner
pythonGH-103903: Test the minimum Sphinx version in CI (python#103904)
5ca3cf9 
(cherry picked from commit 44b5c21)
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
@AA-Turner
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
8749b80 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
@AA-Turner
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
d255ecc 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

GH-103948 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 27, 2023
AlexWaygood pushed a commit that referenced this pull request Apr 27, 2023
@AA-Turner
[3.11] GH-103903: Test the minimum Sphinx version in CI (#103904) (#1…
dbc44fa 
…03948)

[3.11] GH-103903: Test the minimum Sphinx version in CI (GH-103904).

(cherry picked from commit 44b5c21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AA-Turner @AlexWaygood @erlend-aasland @hugovk @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.