GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-99380: Update to Sphinx 7 by AA-Turner · Pull Request #99381 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Nov 11, 2022 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Preview: https://cpython-previews--99381.org.readthedocs.build/en/99381/

  • Issue: Update to Sphinx 7 #99380

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
m-aciek and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@AA-Turner
Update to Sphinx 5.3.0
bedc38d
@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
Update to Sphinx 7 #99380
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 11, 2022
@AA-Turner AA-Turner added skip news awaiting review and removed awaiting review labels Nov 11, 2022
@AA-Turner AA-Turner self-assigned this Nov 11, 2022
@AA-Turner

AA-Turner commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Rendered: https://github.com/python/cpython/suites/9258549124/artifacts/433345867
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 11, 2022
@hugovk

This comment was marked as resolved.

Sign in to view
@AA-Turner

This comment was marked as resolved.

Sign in to view
@AA-Turner AA-Turner added the DO-NOT-MERGE label Nov 11, 2022
@AA-Turner AA-Turner mentioned this pull request Nov 11, 2022
Update python-docs-theme to work with Sphinx 5 & 6 python/python-docs-theme#99
Merged
@hugovk hugovk removed the needs backport to 3.10 label Apr 7, 2023
AA-Turner added 4 commits April 20, 2023 21:13
@AA-Turner
Update to Sphinx 6.1.3
4c2b811
@AA-Turner
Temporary: Use git p-d-t
7816c8d
@AA-Turner
Synchronise
697280b
@AA-Turner
Fix URL
53ec41d
@AA-Turner AA-Turner mentioned this pull request Apr 20, 2023
Releasing v2023.5 python/python-docs-theme#126
Merged
AA-Turner added 2 commits April 20, 2023 22:53
@AA-Turner
Update to p-d-t PR 127
4ce7a41
@AA-Turner
Fix p-d-t PR 127 git install
2486677
@AA-Turner AA-Turner mentioned this pull request Apr 20, 2023
Don't duplicate the sidebar button on Sphinx 5 and newer python/python-docs-theme#127
Merged
@AA-Turner

This comment was marked as resolved.

Sign in to view
@arhadthedev arhadthedev changed the title gh-99380: Update to Sphinx 5.3.0 gh-99380: Update to Sphinx 6.1.3 Apr 21, 2023
@CAM-Gerlach
Merge branch 'main' into sphinx-5
b17d4d3
@CAM-Gerlach

CAM-Gerlach commented Apr 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Especially if we're going to backport this change to 3.11 (which might also enable the dark theme there), we should add a job to build the docs on the minimum Sphinx version specified in the conf.py, so we can continue to verify everything will build (without warnings) on the minimum version we support redistributors using, as we have for the past. This will allow us to be more flexible with keeping all supported docs versions in sync and up to date with the latest Sphinx changes and improvements.

We also have to consider if we want to retain the now opt-out option for listing functions, classes, etc. in the toctree enabled, since this PR effectively flips that switch. Maybe it should be disabled for now and enabled in a separate PR after appropriate discussion (on Discourse, etc)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

We've spoken about a minimum build for a while -- whilst I don't think it should block this work, I'll open a new PR to that effect (do you think we need a new issue to discuss that?).

I'm biased, as I added the feature, but I think it is a real usability win to have the direct links, and so long as the theme responds reasonably (eg on long names), which I'll test, I think we should keep the defaults as a net benefit (especially in reference-type documentation).

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

Cross-linking #103904 for the oldest-supported testing.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

To resolve: ToC directives, e.g. https://deploy-preview-99381--python-cpython-preview.netlify.app/library/index.html

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Revert "Temporary: Use git p-d-t"
eeaf03a 
This reverts commit 7816c8d
@hugovk hugovk added the needs backport to 3.12 only security fixes label Aug 4, 2023
@hugovk hugovk mentioned this pull request Aug 4, 2023
Docs: upgrade to python-docs-theme 2023.7 #107617
Merged
AA-Turner added 2 commits August 6, 2023 05:07
@AA-Turner
Merge branch 'main' into sphinx-5
6bfc9b9 
# Conflicts:
#	Doc/requirements.txt
#	Doc/tools/extensions/pyspecific.py
@AA-Turner
Bump to Sphinx 7.1
ff16c8a
hugovk
hugovk reviewed Aug 6, 2023
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits August 8, 2023 21:03
@AA-Turner
Merge branch 'main' into sphinx-5
8e928c2
@AA-Turner
Restore accidentally removed imports
a227b46
hugovk
hugovk reviewed Oct 17, 2023
View reviewed changes
Comment thread Doc/requirements.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk and others added 3 commits December 21, 2023 17:28
@hugovk
Bump to Sphinx 7.2
e793f43
@hugovk
Merge branch 'main' into sphinx-5
8ff38d1
@AA-Turner
Merge branch 'main' into sphinx-5
ad9b77e
@AA-Turner AA-Turner removed the DO-NOT-MERGE label Jan 20, 2024
@AA-Turner
AA-Turner merged commit e649515 into python:main Jan 20, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the sphinx-5 branch January 20, 2024 11:20
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 20, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e6495159f6f2ca4fe3b5143c62fc2ad5873ef54f 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e6495159f6f2ca4fe3b5143c62fc2ad5873ef54f 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jan 20, 2024

Copy link
Copy Markdown

GH-114341 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 20, 2024
@bedevere-app

bedevere-app Bot commented Jan 20, 2024

Copy link
Copy Markdown

GH-114342 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 20, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jan 20, 2024
@AA-Turner
[3.12] pythonGH-99380: Update to Sphinx 7 (pythonGH-99381).
ae7251c 
(cherry picked from commit e649515)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jan 20, 2024
@AA-Turner
[3.12] GH-99380: Update to Sphinx 7 (GH-99381) (#114341)
82ad785 
(cherry picked from commit e649515)
AA-Turner added a commit that referenced this pull request Jan 20, 2024
@AA-Turner
[3.11] GH-99380: Update to Sphinx 7 (GH-99381) (#114342)
8e17470 
(cherry picked from commit e649515)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@AA-Turner @kulikjak
pythonGH-99380: Update to Sphinx 7 (python#99381)
b71271e
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AA-Turner @aisk
pythonGH-99380: Update to Sphinx 7 (python#99381)
14a50b8
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @Glyphack
pythonGH-99380: Update to Sphinx 7 (python#99381)
93ecdf6
@hugovk hugovk mentioned this pull request Oct 31, 2026
Docs: Upgrade Sphinx to 9.1 #159945
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @hugovk @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.