GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED by ericsnowcurrently · Pull Request #104205 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Here we are doing no more than adding the value for Py_mod_multiple_interpreters. We will start checking for it in gh-104206 (once PyInterpreterState.ceval.own_gil is added in gh-104204).

  • Issue: Implement PEP 684: A Per-Interpreter GIL #99113

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label May 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Implement PEP 684: A Per-Interpreter GIL #99113
Closed
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review May 5, 2023 16:57
@ericsnowcurrently
ericsnowcurrently requested review from a team, 1st1, AlexWaygood, Fidget-Spinner, JelleZijlstra, abalkin, asvetlov, berkerpeksag, brettcannon, corona10, encukou, erlend-aasland, gpshead, gvanrossum, isidentical, kumaraditya303, ncoghlan, pablogsal, pganssle, rhettinger, tiran, warsaw and willingc as code owners May 5, 2023 16:57
@ericsnowcurrently
ericsnowcurrently removed request for a team, JelleZijlstra, gvanrossum and rhettinger May 5, 2023 16:57
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 5, 2023
gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED #104206
Merged
@erlend-aasland
erlend-aasland self-requested a review May 5, 2023 16:59
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 5, 2023
gh-99113: A Per-Interpreter GIL! #99114
Closed
2 of 3 tasks
@ericsnowcurrently ericsnowcurrently removed the skip news label May 5, 2023
@erlend-aasland

erlend-aasland commented May 5, 2023

Copy link
Copy Markdown
Contributor

FYI, there are now two NEWS entries in this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented May 5, 2023

Copy link
Copy Markdown
Member Author

Yeah, one is from gh-104148.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED.
a1b027a
@ericsnowcurrently
ericsnowcurrently force-pushed the per-interpreter-gil-extension-check branch 2 times, most recently from 532330d to a1b027a Compare May 5, 2023 20:21
@ericsnowcurrently ericsnowcurrently added the skip news label May 5, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 5, 2023
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) May 5, 2023 20:27
erlend-aasland
erlend-aasland approved these changes May 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 5, 2023
@ericsnowcurrently
Fix all the modules.
72288a3
@ericsnowcurrently
ericsnowcurrently disabled auto-merge May 5, 2023 20:33
@ericsnowcurrently

ericsnowcurrently commented May 5, 2023

Copy link
Copy Markdown
Member Author

Sorry for any noise here. I realized it would be better to add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED now, while we wait for gh-104204.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) May 5, 2023 20:34
erlend-aasland
erlend-aasland reviewed May 5, 2023
View reviewed changes
Comment thread Modules/_curses_panel.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently ericsnowcurrently mentioned this pull request May 5, 2023
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
@ericsnowcurrently
Use Py_MOD_MULTIPLE_INTERPRETERS_NOT_SUPPORTED for modules with incom…
6849fa5
…plete isolation.
erlend-aasland
erlend-aasland reviewed May 5, 2023
View reviewed changes
Comment thread Modules/faulthandler.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
ericsnowcurrently merged commit a9c6e06 into python:main May 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 5, 2023
@ericsnowcurrently
ericsnowcurrently deleted the per-interpreter-gil-extension-check branch May 5, 2023 21:12
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
baacf5f
* main:
  pythongh-99113: Add PyInterpreterConfig.own_gil (pythongh-104204)
  pythongh-104146: Remove unused var 'parser_body_declarations' from clinic.py (python#104214)
  pythongh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (pythongh-104205)
  pythongh-104108: Add the Py_mod_multiple_interpreters Module Def Slot (pythongh-104148)
  pythongh-99113: Share the GIL via PyInterpreterState.ceval.gil (pythongh-104203)
  pythonGH-100479: Add `pathlib.PurePath.with_segments()` (pythonGH-103975)
  pythongh-69152: Add _proxy_response_headers attribute to HTTPConnection (python#26152)
  pythongh-103533: Use PEP 669 APIs for cprofile (pythonGH-103534)
  pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523. (pythonGH-96849)
ericsnowcurrently added a commit that referenced this pull request May 6, 2023
@ericsnowcurrently
gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (gh-10…
fff193b
…4206)

Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in gh-104205.
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@ericsnowcurrently @jbower-fb
pythongh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (pythongh-10…
7192a46
…4205)

Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules.  We will start checking for it in pythongh-104206 (once PyInterpreterState.ceval.own_gil is added in pythongh-104204).
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@ericsnowcurrently @jbower-fb
pythongh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (p…
fc1e63f
…ythongh-104206)

Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in pythongh-104205.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.