GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101819: Remove unused 'locale_module' from _io state by erlend-aasland · Pull Request #104246 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Isolate the _io extension module #101819

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-101819: Remove unused 'locale_module' from _io state
dea5a25
@erlend-aasland erlend-aasland added the skip news label May 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 6, 2023
Isolate the _io extension module #101819
Closed
@bedevere-bot bedevere-bot added the awaiting core review label May 6, 2023
@erlend-aasland

erlend-aasland commented May 6, 2023

Copy link
Copy Markdown
Contributor Author

I consider this a non-controversial and straight-forward change, where an unused PyObject is simply removed from module state. I'll merge as soon as the CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 6, 2023 20:17
@erlend-aasland
erlend-aasland merged commit 3b14b51 into python:main May 6, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 6, 2023
@erlend-aasland
erlend-aasland deleted the isolate-io/remove-locale branch May 6, 2023 20:37
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-101819: Remove unused 'locale_module' from _io state (python…
060a31e 
…#104246)

The locale module reference was introduced by 932ff83 in 2013,
and rendered unused by 710e826 (pythongh-23050) in 2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.