GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42208: Add _Py_GetLocaleEncoding() by vstinner · Pull Request #23050 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 30, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

_io.TextIOWrapper no longer calls getpreferredencoding(False) of
_bootlocale to get the locale encoding, but calls
_Py_GetLocaleEncoding() instead.

https://bugs.python.org/issue42208

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-42208: Add _Py_GetLocaleEncoding()
f86db86 
_io.TextIOWrapper no longer calls getpreferredencoding(False) of
_bootlocale to get the locale encoding, but calls
_Py_GetLocaleEncoding() instead.
@vstinner vstinner added the skip news label Oct 30, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 30, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Oct 30, 2020
vstinner added 2 commits October 31, 2020 00:33
@vstinner
bpo-42208: Add config_get_fs_encoding() function
5299006 
Reorganize also config_get_locale_encoding() code.
@vstinner
Enhance comments
0820507
@vstinner
vstinner merged commit 710e826 into python:master Oct 31, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 31, 2020
@vstinner
vstinner deleted the get_locale_encoding branch October 31, 2020 00:05
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-42208: Add _Py_GetLocaleEncoding() (pythonGH-23050)
59d4856 
_io.TextIOWrapper no longer calls getpreferredencoding(False) of
_bootlocale to get the locale encoding, but calls
_Py_GetLocaleEncoding() instead.

Add config_get_fs_encoding() sub-function. Reorganize also
config_get_locale_encoding() code.
erlend-aasland added a commit that referenced this pull request May 6, 2023
@erlend-aasland
gh-101819: Remove unused 'locale_module' from _io state (#104246)
3b14b51 
The locale module reference was introduced by 932ff83 in 2013,
and rendered unused by 710e826 (gh-23050) in 2020.
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-101819: Remove unused 'locale_module' from _io state (python…
060a31e 
…#104246)

The locale module reference was introduced by 932ff83 in 2013,
and rendered unused by 710e826 (pythongh-23050) in 2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.