GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-104018: remove unused format "z" handling in string formatfloat() (GH-104107) by miss-islington · Pull Request #104260 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a cleanup overlooked in PR GH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte [email protected]

  • Issue: "z" format specifier is treated differently in unicode and bytes #104018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@belm0 @miss-islington
pythongh-104018: remove unused format "z" handling in string formatfl…
eea8edc 
…oat() (pythonGH-104107)

This is a cleanup overlooked in PR pythonGH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
@miss-islington
miss-islington requested a review from isidentical as a code owner May 7, 2023 04:41
This was referenced May 7, 2023
"z" format specifier is treated differently in unicode and bytes #104018
Closed
gh-104018: remove unused format "z" handling in string formatfloat() #104107
Merged
@bedevere-bot bedevere-bot added awaiting review skip news labels May 7, 2023
kumaraditya303
kumaraditya303 approved these changes May 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 7, 2023
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) May 7, 2023 04:42
@kumaraditya303
kumaraditya303 merged commit 15ffcf7 into python:3.11 May 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 7, 2023
@miss-islington
miss-islington deleted the backport-69621d1-3.11 branch May 7, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @kumaraditya303 @bedevere-bot @belm0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.