GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104018: remove unused format "z" handling in string formatfloat() by belm0 · Pull Request #104107 · python/cpython

Conversation

@belm0

@belm0 belm0 commented May 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a cleanup overlooked in PR #104033.

Please skip NEWS.

  • Issue: "z" format specifier is treated differently in unicode and bytes #104018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label May 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 2, 2023
"z" format specifier is treated differently in unicode and bytes #104018
Closed
@belm0 belm0 changed the title gh-104018: remove unused format "z" handling in string objects gh-104018: remove unused format "z" handling in string formatfloat() May 2, 2023
@belm0
belm0 marked this pull request as draft May 2, 2023 22:15
@belm0
pythongh-104018: remove unused format "z" handling in string formatfl…
a3be962 
…oat()

This is a cleanup overlooked in PR python#104033.

Please skip NEWS.
@belm0
belm0 force-pushed the z_format_object_cleanup branch from 35ba4e4 to a3be962 Compare May 2, 2023 22:23
@belm0
belm0 marked this pull request as ready for review May 2, 2023 22:23
@belm0
belm0 requested a review from isidentical as a code owner May 2, 2023 22:23
@arhadthedev arhadthedev added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes labels May 3, 2023
mdickinson
mdickinson approved these changes May 3, 2023
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 3, 2023
kumaraditya303
kumaraditya303 approved these changes May 7, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit 69621d1 into python:main May 7, 2023
@miss-islington

miss-islington commented May 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @belm0 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 7, 2023
@bedevere-bot

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

GH-104260 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2023
@belm0 @miss-islington
pythongh-104018: remove unused format "z" handling in string formatfl…
eea8edc 
…oat() (pythonGH-104107)

This is a cleanup overlooked in PR pythonGH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@miss-islington @belm0
[3.11] gh-104018: remove unused format "z" handling in string formatf…
15ffcf7 
…loat() (GH-104107) (#104260)

gh-104018: remove unused format "z" handling in string formatfloat() (GH-104107)

This is a cleanup overlooked in PR GH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
@belm0
belm0 deleted the z_format_object_cleanup branch May 7, 2023 10:50
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@belm0 @jbower-fb
pythongh-104018: remove unused format "z" handling in string formatfl…
06707b9 
…oat() (python#104107)

This is a cleanup overlooked in PR python#104033.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@isidentical isidentical Awaiting requested review from isidentical
+1 more reviewer
@mdickinson mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@belm0 @miss-islington @bedevere-bot @mdickinson @kumaraditya303 @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.