GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104018: disallow "z" format specifier in %-format of byte strings by belm0 · Pull Request #104033 · python/cpython

Conversation

@belm0

@belm0 belm0 commented May 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PEP-0682 specified that %-formatting would not support the "z" specifier, but it was unintentionally allowed for a byte strings.

  • Issue: "z" format specifier is treated differently in unicode and bytes #104018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@belm0
pythongh-104018: disallow "z" format specifier in %-format of byte st…
f697407
…rings

PEP-0682 specified that %-formatting would not support the "z"
specifier, but it was unintentionally allowed for a byte strings.

Issue: python#104018
@bedevere-bot bedevere-bot added the awaiting review label May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
"z" format specifier is treated differently in unicode and bytes #104018
Closed
@blurb-it
📜🤖 Added by blurb_it.
ffe6f51
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 1, 2023
mdickinson
mdickinson approved these changes May 1, 2023
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd regard this as a bugfix, and as such, I think it's safe to backport to 3.11.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 1, 2023
@mdickinson mdickinson added the needs backport to 3.11 only security fixes label May 1, 2023
@mdickinson
mdickinson merged commit 3ed8c88 into python:main May 1, 2023
@miss-islington

miss-islington commented May 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @belm0 for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 1, 2023
@bedevere-bot

bedevere-bot commented May 1, 2023

Copy link
Copy Markdown

GH-104058 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2023
@belm0 @blurb-it @miss-islington
pythongh-104018: disallow "z" format specifier in %-format of byte st…
e18148a
…rings (pythonGH-104033)

PEP-0682 specified that %-formatting would not support the "z" specifier,
but it was unintentionally allowed for bytes. This PR makes use of the "z"
flag an error for %-formatting in a bytestring.

Issue: pythonGH-104018

---------

(cherry picked from commit 3ed8c88)

Co-authored-by: John Belmonte <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
mdickinson pushed a commit that referenced this pull request May 1, 2023
@miss-islington @belm0 @blurb-it
[3.11] gh-104018: disallow "z" format specifier in %-format of byte s…
10db28b
…trings (GH-104033) (#104058)

gh-104018: disallow "z" format specifier in %-format of byte strings (GH-104033)

PEP-0682 specified that %-formatting would not support the "z" specifier,
but it was unintentionally allowed for bytes. This PR makes use of the "z"
flag an error for %-formatting in a bytestring.

Issue: GH-104018

---------

(cherry picked from commit 3ed8c88)

Co-authored-by: John Belmonte <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
belm0 added a commit to belm0/cpython that referenced this pull request May 2, 2023
@belm0
pythongh-104018: remove unused format "z" handling in string objects
35ba4e4
This is a cleanup missed in PR python#104033.

Please skip NEWS.
@belm0 belm0 mentioned this pull request May 2, 2023
gh-104018: remove unused format "z" handling in string formatfloat() #104107
Merged
@belm0
belm0 deleted the z_format_bytes branch May 2, 2023 22:04
belm0 added a commit to belm0/cpython that referenced this pull request May 2, 2023
@belm0
pythongh-104018: remove unused format "z" handling in string formatfl…
a3be962
…oat()

This is a cleanup overlooked in PR python#104033.

Please skip NEWS.
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@belm0
gh-104018: remove unused format "z" handling in string formatfloat() (#…
69621d1
…104107)

This is a cleanup overlooked in PR #104033.
@miss-islington miss-islington mentioned this pull request May 7, 2023
[3.11] gh-104018: remove unused format "z" handling in string formatfloat() (GH-104107) #104260
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2023
@belm0 @miss-islington
pythongh-104018: remove unused format "z" handling in string formatfl…
eea8edc
…oat() (pythonGH-104107)

This is a cleanup overlooked in PR pythonGH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@miss-islington @belm0
[3.11] gh-104018: remove unused format "z" handling in string formatf…
15ffcf7
…loat() (GH-104107) (#104260)

gh-104018: remove unused format "z" handling in string formatfloat() (GH-104107)

This is a cleanup overlooked in PR GH-104033.
(cherry picked from commit 69621d1)

Co-authored-by: John Belmonte <[email protected]>
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@belm0 @jbower-fb
pythongh-104018: remove unused format "z" handling in string formatfl…
06707b9
…oat() (python#104107)

This is a cleanup overlooked in PR python#104033.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mdickinson mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@belm0 @miss-islington @bedevere-bot @mdickinson @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.