GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101819: Refactor _io futher in preparation for module isolation by erlend-aasland · Pull Request #104369 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In fileio.c:

  • Replace query with parameter in err_mode()
  • Fetch module state by defining class in:
    • _io.FileIO.read
    • _io.FileIO.readinto
    • _io.FileIO.truncate
    • _io.FileIO.write

In textio.c:

  • Replace query with parameter in _unsupported()

In winconsoleio.c:

  • Replace query with parameter in err_mode()
  • Replace query with parameter in readinto()
  • Fetch module state by defining class in:
    • _WindowsConsoleIO.read
    • _WindowsConsoleIO.readinto
    • _WindowsConsoleIO.write
  • Issue: Isolate the _io extension module #101819

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland added 11 commits May 10, 2023 22:45
@erlend-aasland
Refactor: replace query with parameter
0bfd278 
Pass module state as parameter to err_mode()
@erlend-aasland
Fetch module state by class in _io.FileIO.readinto
8196135
@erlend-aasland
Fetch module state by class in _io.FileIO.read
9584041
@erlend-aasland
Fetch module state by class in _io.FileIO.write
097f147
@erlend-aasland
Fetch module state by class in _io.FileIO.truncate
c4e0940
@erlend-aasland
Refactor: replace query with parameter
7f34d0a 
Pass module state to _unsupported() in textio.c
@erlend-aasland
Fetch module state by class in _WindowsConsoleIO.close
cc1c8f8
@erlend-aasland
Refactor: replace query with parameter
0b3d502 
Pass module state to err_mode() in winconsoleio.c
@erlend-aasland
Refactor: change function declaration
c07026f 
Pass defining class to:

- _WindowsConsoleIO.read
- _WindowsConsoleIO.readinto
- _WindowsConsoleIO.write
@erlend-aasland
Refactor: replace query with parameter
6fbda70 
Pass module state to readinto() in winconsoleio.c
@erlend-aasland
Fetch module state by class where possible in winconsoleio.c
50399ab
@erlend-aasland erlend-aasland added the skip news label May 10, 2023
@erlend-aasland
erlend-aasland requested review from kumaraditya303 and vstinner May 10, 2023 21:30
@bedevere-bot bedevere-bot added the awaiting core review label May 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 10, 2023
Isolate the _io extension module #101819
Closed
@erlend-aasland

erlend-aasland commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

(The diff looks scarier than it is, bco. the clinic changes; without generated files, the diff is 3 files changed, 91 insertions(+), 63 deletions(-))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes May 11, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 11, 2023
@kumaraditya303
kumaraditya303 merged commit d0a738c into python:main May 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 11, 2023
@kumaraditya303
kumaraditya303 deleted the isolate-io/refactor-part2 branch May 11, 2023 10:26
vstinner
vstinner reviewed May 11, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review after merge: LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
19b3d9e 
* main: (27 commits)
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  ...
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
4456dd6 
* main:
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
@cjwatson cjwatson mentioned this pull request Aug 15, 2024
Tests fail on Python 3.12 zopefoundation/zope.file#13
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @vstinner @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.