GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic by erlend-aasland · Pull Request #104355 · python/cpython

Conversation

erlend-aasland commented May 10, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Make sure the defining class is passed to all methods,
so we can easily fetch module state from them in the future.

Issue: Isolate the _io extension module #101819

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument C…

98dd91b

…linic

Make sure the defining class is passed to all methods,
so we can easily fetch module state from them in the future.

erlend-aasland added the skip news label

May 10, 2023

erlend-aasland requested review from kumaraditya303 and vstinner

May 10, 2023 11:10

bedevere-bot mentioned this pull request

May 10, 2023

Isolate the _io extension module #101819

Closed

bedevere-bot added the awaiting core review label

May 10, 2023

arhadthedev reviewed

May 10, 2023

View reviewed changes

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Wrap docstrings

fc14019

kumaraditya303 previously approved these changes

May 10, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 10, 2023

kumaraditya303 reviewed

May 10, 2023

View reviewed changes

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 dismissed their stale review

May 10, 2023 11:36

pressed wrong button

bedevere-bot added awaiting review and removed awaiting merge labels

May 10, 2023

kumaraditya303 reviewed

May 10, 2023

View reviewed changes

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 reviewed

May 10, 2023

View reviewed changes

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 3 commits

May 10, 2023 14:40


          Add missing *args

34c3e99


          ..but not detach()

7c785b3


          Use consistent mood, since we're touching this anyways

28fc57e

erlend-aasland commented May 10, 2023

Copy link

Copy Markdown

Contributor Author

@AlexWaygood, would you mind taking a look at the docstrings. I exploited this possibility to tweak them a little bit (consistent mood, etc.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reviewed

May 10, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings look good -- two small points!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_io/bufferedio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 approved these changes

May 10, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 10, 2023


          Address docstring review

940db40

erlend-aasland merged commit ce8d3db into python:main

May 10, 2023

bedevere-bot removed the awaiting merge label

May 10, 2023

erlend-aasland deleted the isolate-io/clinic branch

May 10, 2023 14:23

carljm added a commit to carljm/cpython that referenced this pull request

May 10, 2023


          Merge branch 'main' into fixloadsuperspec

5976df9

* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)

vstinner reviewed

May 11, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review after merge: LGTM.

The doc and docstring can be improved, but it's unrelated to this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Modules/_io/bufferedio.c


		cls: defining_class
		/
		*args: object

vstinner May 11, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the signature is wrong and should be fixed. It should have 1 optional positional argument, maybe called size. Look at other read() functions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

erlend-aasland May 11, 2023

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did think about that. I also think AC should be able to attach Py_UNUSED to unused arguments (I'm working on that.) I'll create a follow-up PR for fixing the clinic input. (This is not the only problematic usage of *args in _io.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_io/bufferedio.c

		return all data until EOF.

		If the argument is positive, and the underlying raw stream is
		not 'interactive', multiple raw reads may be issued to satisfy

vstinner May 11, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to clarify what "interactive" means. I suppose that it's related to "is it a TTY?" test.

The doc uses the same phrasing: https://docs.python.org/dev/library/io.html#io.BufferedIOBase.read

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

erlend-aasland May 11, 2023

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Let's improve that in a separate issue/PR. Good observation, though!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

carljm added a commit to carljm/cpython that referenced this pull request

May 11, 2023


          Merge branch 'main' into supermon

19b3d9e

* main: (27 commits)
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  ...

Reviewers

vstinner

vstinner left review comments

arhadthedev

arhadthedev left review comments

AlexWaygood

AlexWaygood left review comments

kumaraditya303

kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented May 10, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 10, 2023

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner May 11, 2023

Choose a reason for hiding this comment

Uh oh!

erlend-aasland May 11, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner May 11, 2023

Choose a reason for hiding this comment

Uh oh!

erlend-aasland May 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented May 10, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.