GeezerVison is showing github.com — gh-104619: never leak comprehension locals to outer locals() by carljm · Pull Request #104637 · python/cpython
Conversation
carljm
commented
May 19, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The initial implementation of PEP 709 didn't bother to clear comprehension locals after an inlined comprehension, if the name was a global outside the comprehension. This was purely an optimization to save a couple extra instructions in this case; it didn't seem necessary to clear the comprehension value, since outer references to the name would use LOAD_GLOBAL anyway and not see the value in fastlocals.
But it is necessary to clear the comprehension local even in this case, because otherwise it will still show up in locals(), or in debugger usage, outside of the comprehension.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
carljm
added a commit
to gsallam/cpython_with_perfmap_apii
that referenced
this pull request
May 20, 2023
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
iritkatriel
Awaiting requested review from iritkatriel
iritkatriel is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.